Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp670639ybi; Fri, 14 Jun 2019 01:11:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJtgZJzlprJ4/2XCBlBODzqKCuJ9Haf+9fsvpybw2UqMC/UkZgAcV/7R2sK0frbYYJetie X-Received: by 2002:a63:dc56:: with SMTP id f22mr19047558pgj.305.1560499892869; Fri, 14 Jun 2019 01:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560499892; cv=none; d=google.com; s=arc-20160816; b=laHTK1kHYVUVUjfvrfd+KNBAB0qQSrC9QsM/OmYj3xBuqHjgnxv+B8RrcXIvP6jUbn 312YpN4ZS5jU/YXdwQqXQGN8sMrDjNrMCHjNLsSfFC3u9nsFx8nJDd9Z8NwwhNk1BioC KnBwlhKQkBS/kXBcDJLyxq38748Cs92ECgf4t43P7UowDD0mKiUeyPlubM9zQp+8Hk+f aRT5iR5agH5RXFmIt0SEVzwJBYoUo0SZ38P2eS0myiqiT6B5f476z1sM/yI2XRAhQkgA 5L/p1MwhlGIaNyQeGmUTrMYFB5XYyjg+0isij5cz3ARiRS6SszJzt7tCgcAHHIGjNoip vCxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=+TWYlQiJ9hP53bkQ/TrgAyKS5mZQ4YP5x3l4/KjvTFY=; b=vArC0Lsp7WRZtZqlZXUPoeB/vdAwSqSr9JqJ2U2KhU4WFhvnur8aAj/PDMhXl5a7C1 cPjVWyMI7AIwIhwhZlN2vMRF/HbPjtVjiSwCcrNUsvfEGMqhNGkEKGR1K9ZQ7SdjevVl k0Wv6xO/JHsb4373jD+UJNyr8ia8ge+NM8u46QEG5bOYeEt0fFLVh5e30T3WtD32tGBy w7iyzNb0WU1cHz2ZFByijgh9rkCDJ3C4irzBtOYLhXVsaip9FXTLRtz367Iq/oDlFB5L Dols47/v7HqvMwwUB16DAt605Q5XFpOjeWDu7rcDoVMvxXolgqkndffAVO38wd7SK5Tw 8UWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12si1677919pfd.79.2019.06.14.01.11.15; Fri, 14 Jun 2019 01:11:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726028AbfFNIJR (ORCPT + 99 others); Fri, 14 Jun 2019 04:09:17 -0400 Received: from mga03.intel.com ([134.134.136.65]:19825 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725845AbfFNIJQ (ORCPT ); Fri, 14 Jun 2019 04:09:16 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 01:09:16 -0700 X-ExtLoop1: 1 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2019 01:09:14 -0700 Date: Fri, 14 Jun 2019 16:08:50 +0800 From: Wei Yang To: Dan Williams Cc: Wei Yang , Linux Kernel Mailing List , Andrew Morton , =?iso-8859-1?B?Suly9G1l?= Glisse , Dave Jiang , Oscar Salvador , Michal Hocko Subject: Re: [PATCH] kernel/memremap.c: use ALIGN/ALIGN_DOWN to calculate align_start/end Message-ID: <20190614080850.GA19846@richard> Reply-To: Wei Yang References: <20190614060143.17867-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 11:06:13PM -0700, Dan Williams wrote: >On Thu, Jun 13, 2019 at 11:02 PM Wei Yang wrote: >> >> The purpose of align_start/end is to expand to SECTION boundary. Use >> ALIGN/ALIGN_DOWN directly is more self-explain and clean. > >I'm actively trying to kill this code [1] so I don't see the need for >this patch. > >[1]: https://lore.kernel.org/lkml/155977193326.2443951.14201009973429527491.stgit@dwillia2-desk3.amr.corp.intel.com/ Ah, thanks :-) -- Wei Yang Help you, Help me