Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1ed66b4e9090b802259aa0fce5da1e22bcaeaafc.camel@suse.de>
Subject: Re: Regression post "HID: core: move Usage Page concatenation to
 Main item"
From:   Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To:     Jean-Baptiste =?ISO-8859-1?Q?Th=E9ou?= <jb@essential.com>,
        Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Fri, 14 Jun 2019 10:52:58 +0200
In-Reply-To: <CAEXycpKJvSsyDQjeCC4YqmtN5tpmO15g8D-_3mrunY-NL1w4Qw@mail.gmail.com>
References: <CAEXycp+Y-x7N_Yr==Xy_CT5K_a1DZYc85w1OUV+cKC5ZN+KB1g@mail.gmail.com>
         <CAEXycpKJvSsyDQjeCC4YqmtN5tpmO15g8D-_3mrunY-NL1w4Qw@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-vUvVMdc+hnSw80DDq5QT"
User-Agent: Evolution 3.32.2 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-vUvVMdc+hnSw80DDq5QT
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2019-06-14 at 09:02 +0900, Jean-Baptiste Th=C3=A9ou wrote:
> Sorry - Please find the public link:
>=20
>=20
https://android.googlesource.com/platform/cts/+/master/tests/tests/hardware=
/res/raw/asus_gamepad_register.json
>=20
> Best regards
>=20
> On Fri, Jun 14, 2019 at 9:01 AM Jean-Baptiste Th=C3=A9ou <jb@essential.co=
m> wrote:
> > Hi,
> >=20
> > This patch (58e75155009cc800005629955d3482f36a1e0eec) is triggering a
> > regression with the following descriptor (report not working as
> > expected)
> >=20
> >=20
https://partner-android.googlesource.com/platform/cts/+/refs/heads/q-fs-rel=
ease/tests/tests/hardware/res/raw/asus_gamepad_register.json
> >=20
> > Didn't see anything obviously wrong with this gamepad descriptor, so
> > not sure what's trigger the regression.
> >=20
> > Thanks a lot
> >=20
> > Best regards

Added Benjamin to the mail thread.

For the record here's the report descritor, I have the feeling the issue is
related to the Usage Page being defined in the middle of the Usage
ennumeration.

0x05, 0x01,         /*  Usage Page (Desktop),               */
0x09, 0x05,         /*  Usage (Gamepad),                    */
0xA1, 0x01,         /*  Collection (Application),           */
0x85, 0x01,         /*      Report ID (1),                  */
0x05, 0x09,         /*      Usage Page (Button),            */
0x0A, 0x01, 0x00,   /*      Usage (01h),                    */
0x0A, 0x02, 0x00,   /*      Usage (02h),                    */
0x0A, 0x04, 0x00,   /*      Usage (04h),                    */
0x0A, 0x05, 0x00,   /*      Usage (05h),                    */
0x0A, 0x07, 0x00,   /*      Usage (07h),                    */
0x0A, 0x08, 0x00,   /*      Usage (08h),                    */
0x0A, 0x0E, 0x00,   /*      Usage (0Eh),                    */
0x0A, 0x0F, 0x00,   /*      Usage (0Fh),                    */
0x0A, 0x0D, 0x00,   /*      Usage (0Dh),                    */
0x05, 0x0C,         /*      Usage Page (Consumer),          */
0x0A, 0x24, 0x02,   /*      Usage (AC Back),                */
0x0A, 0x23, 0x02,   /*      Usage (AC Home),                */
0x15, 0x00,         /*      Logical Minimum (0),            */
0x25, 0x01,         /*      Logical Maximum (1),            */
0x75, 0x01,         /*      Report Size (1),                */
0x95, 0x0B,         /*      Report Count (11),              */
0x81, 0x02,         /*      Input (Variable),               */
0x75, 0x01,         /*      Report Size (1),                */
0x95, 0x01,         /*      Report Count (1),               */
0x81, 0x03,         /*      Input (Constant, Variable),     */
0x05, 0x01,         /*      Usage Page (Desktop),           */
0x75, 0x04,         /*      Report Size (4),                */
0x95, 0x01,         /*      Report Count (1),               */
0x25, 0x07,         /*      Logical Maximum (7),            */
0x46, 0x3B, 0x01,   /*      Physical Maximum (315),         */
0x66, 0x14, 0x00,   /*      Unit (Degrees),                 */
0x09, 0x39,         /*      Usage (Hat Switch),             */
0x81, 0x42,         /*      Input (Variable, Null State),   */
0x66, 0x00, 0x00,   /*      Unit,                           */
0x09, 0x01,         /*      Usage (Pointer),                */
0xA1, 0x00,         /*      Collection (Physical),          */
0x09, 0x30,         /*          Usage (X),                  */
0x09, 0x31,         /*          Usage (Y),                  */
0x09, 0x32,         /*          Usage (Z),                  */
0x09, 0x35,         /*          Usage (Rz),                 */
0x05, 0x02,         /*          Usage Page (Simulation),    */
0x09, 0xC5,         /*          Usage (C5h),                */
0x09, 0xC4,         /*          Usage (C4h),                */
0x15, 0x00,         /*          Logical Minimum (0),        */
0x26, 0xFF, 0x00,   /*          Logical Maximum (255),      */
0x35, 0x00,         /*          Physical Minimum (0),       */
0x46, 0xFF, 0x00,   /*          Physical Maximum (255),     */
0x75, 0x08,         /*          Report Size (8),            */
0x95, 0x06,         /*          Report Count (6),           */
0x81, 0x02,         /*          Input (Variable),           */
0xC0,               /*      End Collection,                 */
0x85, 0x02,         /*      Report ID (2),                  */
0x05, 0x08,         /*      Usage Page (LED),               */
0x0A, 0x01, 0x00,   /*      Usage (01h),                    */
0x0A, 0x02, 0x00,   /*      Usage (02h),                    */
0x0A, 0x03, 0x00,   /*      Usage (03h),                    */
0x0A, 0x04, 0x00,   /*      Usage (04h),                    */
0x15, 0x00,         /*      Logical Minimum (0),            */
0x25, 0x01,         /*      Logical Maximum (1),            */
0x75, 0x01,         /*      Report Size (1),                */
0x95, 0x04,         /*      Report Count (4),               */
0x91, 0x02,         /*      Output (Variable),              */
0x75, 0x04,         /*      Report Size (4),                */
0x95, 0x01,         /*      Report Count (1),               */
0x91, 0x03,         /*      Output (Constant, Variable),    */
0xC0,               /*  End Collection,                     */
0x05, 0x0C,         /*  Usage Page (Consumer),              */
0x09, 0x01,         /*  Usage (Consumer Control),           */
0xA1, 0x01,         /*  Collection (Application),           */
0x85, 0x03,         /*      Report ID (3),                  */
0x05, 0x01,         /*      Usage Page (Desktop),           */
0x09, 0x06,         /*      Usage (Keyboard),               */
0xA1, 0x02,         /*      Collection (Logical),           */
0x05, 0x06,         /*          Usage Page (Device),        */
0x09, 0x20,         /*          Usage (20h),                */
0x15, 0x00,         /*          Logical Minimum (0),        */
0x26, 0xFF, 0x00,   /*          Logical Maximum (255),      */
0x75, 0x08,         /*          Report Size (8),            */
0x95, 0x01,         /*          Report Count (1),           */
0x81, 0x02,         /*          Input (Variable),           */
0x06, 0xBC, 0xFF,   /*          Usage Page (FFBCh),         */
0x0A, 0xAD, 0xBD,   /*          Usage (BDADh),              */
0x75, 0x08,         /*          Report Size (8),            */
0x95, 0x06,         /*          Report Count (6),           */
0x81, 0x02,         /*          Input (Variable),           */
0xC0,               /*      End Collection,                 */
0xC0                /*  End Collection                      */

Regads,
Nicolas


--=-vUvVMdc+hnSw80DDq5QT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl0DYGoACgkQlfZmHno8
x/7ezQf9EQ5JRPsaKyw22IbaVutfURgVDxl7aIYP0GoM4XdS/1kyx/Yb98dLZoQa
S+6EbrRCAowQCyK4+MfI5a/zK4rO+dMTvg8MH7En8D7AfbKAFINylZ7eSwcDOksB
j+8uixX+t8v7rruTts888F2hKEYdVyCzdjj/IQPvvd0Oo7f+JdfTCHoaPnWJfXx3
9o+HpZ+G3RnuVfxW0eDi6ZjGfz3TVZTPiCP0cGNQgPD/5yt0HuUdoEY28I3a1pKp
JT5oyggC1P846WmhSr5ypZPK8JCpd3azX7utoc+cV71E0wg5XQx8thNFyiFaIrRk
F9ZCPohqQzVGT4ZxgYEZU1EZPnWcmA==
=Q7cT
-----END PGP SIGNATURE-----

--=-vUvVMdc+hnSw80DDq5QT--