Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Jun 2019 13:45:11 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Furquan Shaikh <furquan@google.com>, Len Brown <lenb@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        rajatja@google.com
Subject: Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling
Message-ID: <20190614104511.GC2640@lahna.fi.intel.com>
References: <20190516193616.252788-1-furquan@google.com>
 <13361760.nMXA0SR1Mq@kreacher>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13361760.nMXA0SR1Mq@kreacher>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 13, 2019 at 10:24:41PM +0200, Rafael J. Wysocki wrote:
> This patch may cause events to be missed if the GPE.  I guess what you reall mean is
> something like the patch below.
> 
> This should allow the kernel to see the events generated before the GPEs are
> implicitly enabled, but it should clear them for the explicit users of acpi_enable_gpe().
> 
> Mika, what do you think?

Looks good to me. I also tested this with two TBT systems (Skull Canyon
NUC and Dell XPS 9370) using ACPI hotplug and it did not cause any
problems if I boot the system with device connected.