Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp904186ybi; Fri, 14 Jun 2019 05:25:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzP8vw5AHPv+Q1IJ0uYZ85LubUhppElI0Vx7zRJHhUyhkEoQav+V85WHnyLhPVlK6xBz1Ff X-Received: by 2002:a63:5d05:: with SMTP id r5mr29545157pgb.222.1560515109959; Fri, 14 Jun 2019 05:25:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560515109; cv=none; d=google.com; s=arc-20160816; b=ln30BMKS4tJZogbdz2mCxtLktYB1G8iep2bBYiWUEwIin0wb7tYoCQXGSzb/U6r24o +b1DnuMVGBgi4++fyrbLjF6j/R9k0+gzYUe9CHMgFyFxD8VG4L5wBAc04bSFal9UBand gtA5anxeceLtcp74wZb/qnnkxRQRM1AxIE+/g4wM3OITxwepsmuBcz9KpSnP+P6m3MgD fq7JGm8wXYs6qoU19CNvN1V6F+6HQTDbp2D3TgGhZJsKRVyuApnEnj85uYfRu+HgFMxr cdykCwgWmcBXhW+RaiJXx0mF6mSaTqnbEeo4Ho/ApFebU1eAYUt+GFLnXl5TJwdmJczP Se4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=lxDPrivx217A6o8qgH0VV7HHHvXWVIPG/gToMX/ocLw=; b=QybWtLTaobe22xqXduxk6+TWT55aXwfICIm5uHEo+jLEIvnKjDlIV4AWDwj6FahGN9 FkhGWUH/woqGjrJumu4ZwXBnWMSAcMJ6mPrKuogMsLjKacfAlUIxIuWJBiKqofF2AC3m mE4tN3mPOs/q9Y90UQOz1uuzO4v0B96xKLk1bOzM+s/OdQ3m7EiT3bw+e0j0JJa7/tLY GutYdY1/SvpFi+wJLQ0QKyaiHsWN+GlMXQERUG+JPMnYi42u1WA2l3SYqWah9yVyKC/x mnrTMipAuw4FBlk1WGDX9OsMTUIJVGgE9ICpomuV+iA4xunP3k8L0XQBAN5+Og5l0yev 7cUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si2449893pgh.530.2019.06.14.05.24.54; Fri, 14 Jun 2019 05:25:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbfFNMYn (ORCPT + 99 others); Fri, 14 Jun 2019 08:24:43 -0400 Received: from foss.arm.com ([217.140.110.172]:32980 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727634AbfFNMYn (ORCPT ); Fri, 14 Jun 2019 08:24:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 957F83EF; Fri, 14 Jun 2019 05:24:42 -0700 (PDT) Received: from [192.168.1.18] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C78263F246; Fri, 14 Jun 2019 05:24:39 -0700 (PDT) Subject: Re: [PATCH v6 03/19] kernel: Unify update_vsyscall implementation To: Thomas Gleixner Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Will Deacon , Arnd Bergmann , Russell King , Ralf Baechle , Paul Burton , Daniel Lezcano , Mark Salyzyn , Peter Collingbourne , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Huw Davies References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-4-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <9371eabc-ed74-3db8-794c-44c37ada2163@arm.com> Date: Fri, 14 Jun 2019 13:25:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/19 1:19 PM, Thomas Gleixner wrote: > On Fri, 14 Jun 2019, Vincenzo Frascino wrote: >> On 6/14/19 12:10 PM, Thomas Gleixner wrote: >>> On Thu, 30 May 2019, Vincenzo Frascino wrote: >>>> + >>>> + if (__arch_use_vsyscall(vdata)) { >>>> + vdata[CS_HRES_COARSE].cycle_last = >>>> + tk->tkr_mono.cycle_last; >>>> + vdata[CS_HRES_COARSE].mask = >>>> + tk->tkr_mono.mask; >>>> + vdata[CS_HRES_COARSE].mult = >>>> + tk->tkr_mono.mult; >>> >>> These line breaks make it really hard to read. Can you fold in the patch >>> below please? >>> >> >> Thanks for this. I will do it in v7. > > Talking about v7. I'd like to get this into 5.3. That means you'd have to > rebase it on > > git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git hyperv-next > > to avoid the hyperv conflict. I'll sort this out with the hyperv folks how > I can get these bits as a base for a tip branch which holds all the vdso > pieces. > Ok, I will rebase and test the patches against the hyperv-next branch. Could you please let me know when all the bits are sorted? > Thanks, > > tglx > -- Regards, Vincenzo