Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Jun 2019 18:02:10 +0530
From:   Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To:     Eiichi Tsukata <devel@etsukata.com>
Cc:     rostedt@goodmis.org, mingo@redhat.com, mhiramat@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tracing/uprobe: Fix obsolete comment on
 trace_uprobe_create()
Reply-To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
References: <20190614074026.8045-1-devel@etsukata.com>
 <20190614074026.8045-2-devel@etsukata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20190614074026.8045-2-devel@etsukata.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Message-Id: <20190614123210.GB16523@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Eiichi Tsukata <devel@etsukata.com> [2019-06-14 16:40:26]:

> Commit 0597c49c69d5 ("tracing/uprobes: Use dyn_event framework for
> uprobe events") cleaned up the usage of trace_uprobe_create(), and the
> function has been no longer used for removing uprobe/uretprobe.
> 

Agree

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> Signed-off-by: Eiichi Tsukata <devel@etsukata.com>
> ---
>  kernel/trace/trace_uprobe.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 7dc8ee55cf84..7860e3f59fad 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -426,8 +426,6 @@ static int register_trace_uprobe(struct trace_uprobe *tu)
>  /*
>   * Argument syntax:
>   *  - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS]
> - *
> - *  - Remove uprobe: -:[GRP/]EVENT
>   */
>  static int trace_uprobe_create(int argc, const char **argv)
>  {
> -- 
> 2.21.0
> 

-- 
Thanks and Regards
Srikar Dronamraju