Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp981537ybi; Fri, 14 Jun 2019 06:41:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7qBkxUxpu5UEvc1RdPpXRGmB924EZPf2JfI+SXqw484KMmMx1h8MIrBUbw+5myMHm3IJR X-Received: by 2002:a62:2b81:: with SMTP id r123mr57311993pfr.108.1560519687568; Fri, 14 Jun 2019 06:41:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560519687; cv=none; d=google.com; s=arc-20160816; b=u+Gi9uYeZAoDD0imLsGvCtnjLRrS/B3/vYTqxvkLt6pIv62VihF0dcbxG/4mR0OGfg hnoKYAUn5mTVnazb+zjDRKGa0K/NbYW4rCwctIb27oyLbNO7O0Ps7p60jJYlobafGq5N FjSkj6kIVzpGDft6SqbizD7Ud8hJAIv9FytTYDEX4JgFTRJiY3FDblxpJcWKTAeoendz MtyruxdnFPKGRHcqiFp7AcivXHTB4vf7djiKB1yXpsyFO21XxLzX1+U33kUzwBvEXlGZ X5X9IelQ/4fnaQVYTgPmNmnbVPJfBeWLnFOVegi7EgyfuhCHxX8742KVs42Qo1RUA2bs AiWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=O95rFqLmx1gqmD991RSkp9dv9JMLhJuRBvQiIY9txys=; b=sjvc+cj4q+jTSBTHs2UgjN3anpu7t6SjMlHG5Nz5BP+3x1X+9r6YGkslZUFnIA74ZI wnElaydLJBrEkIzZnCsUeAKQXPQzbClpJ6O5nYmZQY2KB9x3GrEUh0bVyw4k1syrM0iL B6VkEgISj1pnFCZR+q8a8hd22clkvaIVdUHb9UX8AkZiR/XfEXcYIwFC4RlbGKbz5hF7 YO0OrqbARVCtvOBhBxN1BeJkCpT4Yca4wsrbUaisHbVcDJj+imReuKIdAQm1QtezkKp9 2JRqGRU9qIeFAjnX21co3VNMjETqjpJJQrFodTEDXvVBPNazNmkj5cMZqoCk8YNSgY17 4O+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="TBo/puD0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h187si2538650pfb.129.2019.06.14.06.41.12; Fri, 14 Jun 2019 06:41:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="TBo/puD0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbfFNNkh (ORCPT + 99 others); Fri, 14 Jun 2019 09:40:37 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44161 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727382AbfFNNkh (ORCPT ); Fri, 14 Jun 2019 09:40:37 -0400 Received: by mail-wr1-f68.google.com with SMTP id r16so2564619wrl.11; Fri, 14 Jun 2019 06:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O95rFqLmx1gqmD991RSkp9dv9JMLhJuRBvQiIY9txys=; b=TBo/puD0AiTUj7kjtDuN2aDY14/t3jTB1niCkcBBUxESNbse7A7m6G20K1Yhp1VLVu mLpv8ZsVu6FYT0UxrLNvQbfyFtZzox3o/IO+0l1XQZFkjqlXl1NJ12c7zn7nGpvlrnlM C3QMnlXe/tTNjQq+xuMHV4dnBR8kQq/oJlnh1UXRIwRORgskahTZHznv7glWGnALwIc+ MIXPdLTjs3Wr4m9QCcuIt05CAqPCcjo1x22Cn5/YDhjwgkcekxtWMwgx43U8m5r2VHz7 eG4jyipd02vIOGRkZtn1lNQqIss7hhhFF0KRCi91fQgqfranOV0xWVBL05Izl2+qtnvP VbyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O95rFqLmx1gqmD991RSkp9dv9JMLhJuRBvQiIY9txys=; b=RAl6KLD4SdtCS2OkDTt8zFrbttVAB6E8mcGt8I3oiaZEfBFzuq5kuu9aSRXo2ef7F5 gCQSpWf9pivhW2bb7lZb8Cmlg4mBslPKwNZs3IN9A8ckRAXB/Jq2LKzSMYEwaU8x7Zn8 2emh+EB8m0ubhJ+J5xSFfN2X//UHQ2WqoIZs/aYyZkJKmCJS/UsW+KLtGvARCD70fWsx i0hEHbB+/iXGSfLPwACLZfxhvfgQFdrHaBY3YinwNYOokXALFVu0UEsV6qbhSPD8tjjt 9zdbKzV+ozWMbTNnwq2L9ArPfnKptXxLwRO2I6qVJTa102976pOuD6gEwr3EyWQH4yL5 Jw0A== X-Gm-Message-State: APjAAAWjKDdtbQv7+inMBnZpmSKQpfkE0QwUn/Tzymf7vFjSnGuyNzug 6xuBDuu/43wm0ZV9JMAdOZp9ADTP X-Received: by 2002:adf:81c8:: with SMTP id 66mr62002750wra.261.1560519635241; Fri, 14 Jun 2019 06:40:35 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id v204sm4946108wma.20.2019.06.14.06.40.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 06:40:34 -0700 (PDT) Date: Fri, 14 Jun 2019 15:40:28 +0200 From: Corentin Labbe To: Jose Abreu Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink Message-ID: <20190614134028.GB23409@Red> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 05:18:44PM +0200, Jose Abreu wrote: > [ Hope this diff looks better (generated with --minimal) ] > > This converts stmmac to use phylink. Besides the code redution this will > allow to gain more flexibility. > > Cc: Joao Pinto > Cc: David S. Miller > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Cc: Russell King > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: Heiner Kallweit > > Jose Abreu (3): > net: stmmac: Prepare to convert to phylink > net: stmmac: Start adding phylink support > net: stmmac: Convert to phylink and remove phylib logic > > drivers/net/ethernet/stmicro/stmmac/Kconfig | 3 +- > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 7 +- > .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 81 +--- > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 391 ++++++++---------- > .../ethernet/stmicro/stmmac/stmmac_platform.c | 21 +- > 5 files changed, 190 insertions(+), 313 deletions(-) > > -- > 2.21.0 > Hello since this patch I hit dwmac-sun8i 1c30000.ethernet: ethernet@1c30000 PHY address 29556736 is too large any idea ?