Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp984716ybi; Fri, 14 Jun 2019 06:44:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkf1WY7wwl4nTvsVZzR+SXYABPhlZswv6w9iYo1WDKmNezx/H5Z5qbpzZIj6Vo+BmHTnt/ X-Received: by 2002:aa7:8f2c:: with SMTP id y12mr14822553pfr.38.1560519883124; Fri, 14 Jun 2019 06:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560519883; cv=none; d=google.com; s=arc-20160816; b=TE0un7A0Pjb2BubJ/XJ4NUdasCnB+sVPZcUyijz0uhKt/h65lBcufQc0iSmGDTJ+xC PWLUOlj0iiWThMSf/fDXc5UGXnPHRqUjR7ABM/GAQ8udntzW0WZlr5Eyw25MJLpIzdJ6 i+o1wEmHdhs5AMXMlnvOzzfSrckb0yMxKSD2mEg7MXzt57FUam3bpb5O2ksFVIV1N/9X Fma5U0RYRVB57yehPUhzP6PlsrIBCgbDYHi2y5qyGocTTzxBfev6+aRtdRQ90rzHEY2z 2/sNvfe9YBFpoISSYDMgOJDkdGlYTOhj2vXvLRgG96zK/Ya44ZkEAf5K5Eij0smROKJZ Sy+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=J2GyUfqQS67B/ePu9DFYzztuljU9tggz5lRR+B4HntQ=; b=y9SILBowni6FD+hLQgbjW8fxwd2xxj0JPl3eJOTxpHTsiKDSOJbxTJlTeR83DMJXhz oguiV6RdjAOBgIE7zFDz4pfOftzRru7czfXeK8UgWMcMH7znNudzjRboHAo05j7CnZCl ca1RjQ8mEHnTQSzpiL/AAAkhg9wkHJSv8Y183pEEHBEr3V+NlQ13iP6j1NxWgbCP7ZB0 JcszC8SIoAQrAhkCBmni7iUQsUZNzfLbuakY09fZ4DVNu3PvYfDeZp7ZwIToGxpt2zS3 4K7dp1tDGiTGw3bHMzxyqTiwe23dYOpxAqFmwtOAJMTFTxpCWLWiKJER2S08qR3Mr14L 5qFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si2534611pfc.54.2019.06.14.06.44.27; Fri, 14 Jun 2019 06:44:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728333AbfFNNmk (ORCPT + 99 others); Fri, 14 Jun 2019 09:42:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57304 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728069AbfFNNmi (ORCPT ); Fri, 14 Jun 2019 09:42:38 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 44F503086202; Fri, 14 Jun 2019 13:42:33 +0000 (UTC) Received: from oldenburg2.str.redhat.com (dhcp-192-180.str.redhat.com [10.33.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A698960469; Fri, 14 Jun 2019 13:42:27 +0000 (UTC) From: Florian Weimer To: Mathieu Desnoyers Cc: carlos , Joseph Myers , Szabolcs Nagy , libc-alpha , Thomas Gleixner , Ben Maurer , Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Will Deacon , Dave Watson , Paul Turner , Rich Felker , linux-kernel , linux-api Subject: Re: [PATCH 1/5] glibc: Perform rseq(2) registration at C startup and thread creation (v10) References: <20190503184219.19266-1-mathieu.desnoyers@efficios.com> <1635690189.3049.1560507249693.JavaMail.zimbra@efficios.com> <87tvcsv1pk.fsf@oldenburg2.str.redhat.com> <1190407525.3131.1560516910936.JavaMail.zimbra@efficios.com> <1085273942.3137.1560517301721.JavaMail.zimbra@efficios.com> <87d0jguxdk.fsf@oldenburg2.str.redhat.com> <1779359826.3226.1560518318701.JavaMail.zimbra@efficios.com> <87wohoti47.fsf@oldenburg2.str.redhat.com> <189377747.3315.1560519247118.JavaMail.zimbra@efficios.com> Date: Fri, 14 Jun 2019 15:42:26 +0200 In-Reply-To: <189377747.3315.1560519247118.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Fri, 14 Jun 2019 09:34:07 -0400 (EDT)") Message-ID: <87imt8tha5.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 14 Jun 2019 13:42:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mathieu Desnoyers: > + /* Publicize rseq registration ownership. This must be performed > + after rtld re-relocation, before invoking constructors of > + preloaded libraries. */ > + rseq_init (); Please add a comment that IFUNC resolvers do not see the initialized value. I think this is okay because we currently do not support access to extern variables in IFUNC resolvers. > /* Do any necessary cleanups for the startup OS interface code. > We do these now so that no calls are made after rtld re-relocation > which might be resolved to different functions than we expect. > > It works fine now! Great. Thanks, Florian