Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Jun 2019 08:09:24 -0700
From:   Tejun Heo <tj@kernel.org>
To:     Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>
Cc:     axboe@kernel.dk, newella@fb.com, clm@fb.com, josef@toxicpanda.com,
        dennisz@fb.com, lizefan@huawei.com, hannes@cmpxchg.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        kernel-team@fb.com, cgroups@vger.kernel.org, ast@kernel.org,
        daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com,
        yhs@fb.com, bpf@vger.kernel.org, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH 08/10] blkcg: implement blk-ioweight
Message-ID: <20190614150924.GB538958@devbig004.ftw2.facebook.com>
References: <20190614015620.1587672-1-tj@kernel.org>
 <20190614015620.1587672-9-tj@kernel.org>
 <87pnngbbti.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87pnngbbti.fsf@toke.dk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello, Toke.

On Fri, Jun 14, 2019 at 02:17:45PM +0200, Toke H?iland-J?rgensen wrote:
> One question: How are equal-weight cgroups scheduled relative to each
> other? Or requests from different processes within a single cgroup for
> that matter? FIFO? Round-robin? Something else?

Once each cgroup got their hierarchical weight and current vtime for
the period, they don't talk to each other.  Each is expected to do the
right thing on their own.  When the period ends, the timer looks at
how the device is performing, how much each used and so on and then
make necessary adjustments.  So, there's no direct cross-cgroup
synchronization.  Each is throttled to their target level
independently.

Within a single cgroup, the IOs are FIFO.  When an IO has enough vtime
credit, it just passes through.  When it doesn't, it always waits
behind any other IOs which are already waiting.

Thanks.

-- 
tejun