Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Jun 2019 23:46:06 +0530
From:   Saiyam Doshi <saiyamdoshi.in@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     groeck@google.com, linux-kernel@vger.kernel.org,
        groeck@chromium.org, adurbin@chromium.org, dlaurie@chromium.org
Subject: Re: [PATCH] gsmi: replace printk with relevant dev_<level>
Message-ID: <20190614181606.GA4448@ahmlpt0706>
References: <20190613185705.GA16951@ahmlpt0706>
 <20190614060919.GA7271@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190614060919.GA7271@kroah.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 14, 2019 at 08:09:19AM +0200, Greg KH wrote:
> On Fri, Jun 14, 2019 at 12:27:05AM +0530, Saiyam Doshi wrote:
> > Replace printk() with dev_* macros for logging consistency.
> > In process of replacing printk with dev_err, dev_info etc.,
> > removed unnecessary "out of memory" debug message.
> 
> That is multiple things done in the same patch, please break this up
> into a patch series, only doing one "logical" thing per patch.

Agreed. I could have broken it into patch set.

> Note, generic cleanup patches like this are tough to get done in the
> "real" part of the kernel, I strongly recommend you start out in
> drivers/staging/ where these types of changes are welcomed.  Get
> experience there and then move out into other areas of the kernel if you
> want to, that way you don't annoy developers/maintainers with basic
> errors like this.
> 
> good luck!

Noted. Thanks Greg for feedback and suggestion.