Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] tracing: Make two symbols static
To:     YueHaibing <yuehaibing@huawei.com>, rostedt@goodmis.org,
        mingo@redhat.com
Cc:     linux-kernel@vger.kernel.org
References: <20190614153210.24424-1-yuehaibing@huawei.com>
From:   "Zanussi, Tom" <tom.zanussi@linux.intel.com>
Message-ID: <8c64a9e1-03c5-8716-9151-23fc5f5f645c@linux.intel.com>
Date:   Fri, 14 Jun 2019 14:58:50 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190614153210.24424-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi YueHaibing,

On 6/14/2019 10:32 AM, YueHaibing wrote:
> Fix sparse warnings:
>
> kernel/trace/trace.c:6927:24: warning:
>   symbol 'get_tracing_log_err' was not declared. Should it be static?
> kernel/trace/trace.c:8196:15: warning:
>   symbol 'trace_instance_dir' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

These look fine to me.

Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Thanks,

Tom


> ---
>   kernel/trace/trace.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index a092e40..650b141 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -6924,7 +6924,7 @@ struct tracing_log_err {
>   
>   static DEFINE_MUTEX(tracing_err_log_lock);
>   
> -struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
> +static struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
>   {
>   	struct tracing_log_err *err;
>   
> @@ -8193,7 +8193,7 @@ static const struct file_operations buffer_percent_fops = {
>   	.llseek		= default_llseek,
>   };
>   
> -struct dentry *trace_instance_dir;
> +static struct dentry *trace_instance_dir;
>   
>   static void
>   init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer);