Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1497477ybi; Fri, 14 Jun 2019 16:25:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2WT8BZO8LPPTKQtYSyvYuWTSKDLv5LIktiQ8pq+HRxppXggMNoPUsw+vpWWqJQDAyulFm X-Received: by 2002:a62:4dc5:: with SMTP id a188mr102697299pfb.8.1560554714288; Fri, 14 Jun 2019 16:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560554714; cv=none; d=google.com; s=arc-20160816; b=mcEUnaDN3uuMkSxRPG32pdr/kW9huoEGTdD0BYIIkId1emEOL1oviJn0ac8RjOPYAH e7VCrFzORV4wWj5P2Uc0tjM1MVNkOaIiYPoxDYOu3Cz7lOBIS20tVHv6rqE/c3SSJ17+ qLsNwh5baB0JYkpldVp0sUxrAtldFOq5we8Paf21oyOkMWD02S6bs6NQboNZQhnkAmWD WPRtnWGcsOG1nHa0nIi4JNgSDuNXUXbk1d0Cw4tcA5tJC+gD0oagL1E8eskvSPbEw338 0q1OILLhjmzdaB+HKFwN+oN8Q6p8VFCzSPpll3wegDzBwS0Ry3FlzIrB/DeqnW7xzwmP a3TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=C4IQUQcS7QrORxNI7m1YHyOig4h9Gn/Ave48TWGHbzU=; b=0U49TaF3DtguA62sFES7OeJrIJrQNjYHqFIMMrUrim4/2Hu2sy2yAq9BUMSm5BHMWO Dqzlw39NEA9CYbgC4z7IMxAXza4B/S9pOBdibLxCGd3Re1RFjb+4d4qWg24f+JAfa0eC 9hWO/jGk8MKZ756NApKyDivc90r5nyn3sGy0T7C4PNcxDiVraIt7VuvAmMbtEIHjwafn lm/leBfcc4Dk1ik1DJiuAbXFR/FZEqyyq+jlj7JPEgwhG+5o9NXC8m92EI9stH0wJ8+W KZ8TPXiDa/qwzx8nN8Ok5TZct6vAF1gakD3eJwj61a9twBmDogtGK1fuNKE/FCXRaEyT nxrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k24si3653355pgj.510.2019.06.14.16.25.00; Fri, 14 Jun 2019 16:25:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbfFNXYa (ORCPT + 99 others); Fri, 14 Jun 2019 19:24:30 -0400 Received: from www62.your-server.de ([213.133.104.62]:41504 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfFNXY3 (ORCPT ); Fri, 14 Jun 2019 19:24:29 -0400 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hbvYL-0008Ll-NO; Sat, 15 Jun 2019 01:24:13 +0200 Received: from [178.199.41.31] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1hbvYL-000HLG-Hh; Sat, 15 Jun 2019 01:24:13 +0200 Subject: Re: [PATCH bpf-next] bpf: Fix build error without CONFIG_INET To: YueHaibing , ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, davem@davemloft.net, jakub.kicinski@netronome.com, jonathan.lemon@gmail.com Cc: linux-kernel@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org References: <20190612091847.23708-1-yuehaibing@huawei.com> From: Daniel Borkmann Message-ID: Date: Sat, 15 Jun 2019 01:24:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190612091847.23708-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25480/Fri Jun 14 10:12:45 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2019 11:18 AM, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > kernel/bpf/verifier.o: In function `check_mem_access': > verifier.c: undefined reference to `bpf_xdp_sock_is_valid_access' > kernel/bpf/verifier.o: In function `convert_ctx_accesses': > verifier.c: undefined reference to `bpf_xdp_sock_convert_ctx_access' > > Reported-by: Hulk Robot > Fixes: fada7fdc83c0 ("bpf: Allow bpf_map_lookup_elem() on an xskmap") > Signed-off-by: YueHaibing Applied, thanks!