Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp423525ybi; Sat, 15 Jun 2019 04:02:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqytSVODsdvsOrACxB5qX6qoB5u87UaTQLjQjmkEussBAfGPF6zHiaYPasal5TRr5o6qmgk/ X-Received: by 2002:a63:e53:: with SMTP id 19mr15265245pgo.137.1560596561829; Sat, 15 Jun 2019 04:02:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560596561; cv=none; d=google.com; s=arc-20160816; b=oZPImqbc9EDlN8IbBUEHg6oIT0DGRIwoS21Sh/GmbAgae5OWCYGX0FXlRZMReqweRL aE5oRuBcKznGdRb9GOdruZP+4Zzygy5r0l4NdEck1AdtuX50WvhUtJIZrp6xb7Rtkv3Z MG26Qb0ud7eFB225F6/5p1Sozk7yv6pZXOY40mZdyGvU0L4eHipRnL/5Ti8pj7GNgMpm Fx5e2lIq4PmiNylPj4nTCGacNaNEn3XJ2GJfoD4QyMSEBt5zdm8LVvtOqPjo7Fru9o3/ hsGIBRcmLmxq0CpHHzOWPgFR08vTLTx73yyPieSk3QnVKcOCoffpc6PMK45eJUw/giNn RGJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=1kCuf/aUH97NdPViC3JlC4Tno3LHpOGnDeOS2S+jmfY=; b=gNBmG25DN+TlODPcEfW9BigGK4FjmCeoLsrPMuTfidzYllmAdybTKkDDFv+tzzsux0 lurjenHvKkUHxvLohV7fXGJiPyhVE/3O1SOUPwWnYeeJD0RGdFLo6hftjiWb8fOrYQ0s L1OG07Zii+9zAIOkvjsNf9oicW02MCecsBDW096Ze9MNDZJZ3/E6EjdXd3Q9ws4yF2hl DNnhCCpN79+CJaMa6ZEYoBggd0AT/R83blD9L7+pdG0nLkaavRJQXuZQwBgRvi3LGAan BfRPf6PVl5Ft0IgiQfFebs8QqKpny3gdPgQzbwnGXK4cRSQjVtJw/sqr0HjXPgUeAvEB XeDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b="Q/GwPIed"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay11si4595197plb.263.2019.06.15.04.02.26; Sat, 15 Jun 2019 04:02:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b="Q/GwPIed"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbfFOLAv (ORCPT + 99 others); Sat, 15 Jun 2019 07:00:51 -0400 Received: from mout.web.de ([212.227.15.4]:52993 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbfFOLAu (ORCPT ); Sat, 15 Jun 2019 07:00:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1560596424; bh=1kCuf/aUH97NdPViC3JlC4Tno3LHpOGnDeOS2S+jmfY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Q/GwPIedEGA857ZUMicN2iaOS4ZdaKfBfrFMfEDyqzZSp0zQRcFlVvmK+QyB+/QtK WwAkDox0QkURJHgvfKYhCC237vyfSEvW5dhEiCTij8sMjGjCF01IYZ2iNTuZdChKL5 aSwYQMObv0Y7webXYjKpaZq2zumuEOpx2g3XB6rY= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.156.60]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MYZ8c-1i7QnC06QE-00VRaB; Sat, 15 Jun 2019 13:00:24 +0200 Subject: Re: drivers: Inline code in devm_platform_ioremap_resource() from two functions To: Julia Lawall , kernel-janitors@vger.kernel.org Cc: Enrico Weigelt , Greg Kroah-Hartman , "Rafael J. Wysocki" , Michal Marek , Nicolas Palix , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org References: <20190406061112.31620-1-himanshujha199640@gmail.com> <7b4fe770-dadd-80ba-2ba4-0f2bc90984ef@web.de> <032e347f-e575-c89c-fa62-473d52232735@web.de> From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <4b4b2d76-7af5-5466-16ea-aad0825578a0@web.de> Date: Sat, 15 Jun 2019 13:00:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:f1PqGVlxhZlaAFuITLkVQb4EAaKvIYzgA+jMj10n5biQ+LwBRav w4cQvk8uXRpdBqr4cm+4XsBY1lCE0DSCWHzroQxIF8nzTg+Rxguyyj3DeN9twVDy4xucz41 K+7gPu/rMksNAsp2UJ0JQCC+T1P/1F6y45vV9NuBn7Wu4TqcbV+UEewx6Ihd6yTGqqOpUXv 7ptJkYurO9YeJqxUQ+3AA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:sox0g212y2o=:XnNl3kzVAJu9PBbWJWfzhO OurJ1O+HBBNshGWlvpw3yrATo9bnEpCNpOoSu4HEBjY9H6o9icmZ7QAWkzjnTlxnkWfFBPeRy SaNirF3fXGFZlz//Y0gS7dKJQ9Mtpp6tg2/FupCihkcfF/V9QjIr1F1NfjAi5R1SXt4Gu2kRy vPi1BxF3GkDytlhgOLbnOHIe7RA9chhjzx6u20DwsPmuyXbIDFIKT2TnPD1RfDz4OFSlVt+pH rEPll1pFa0d04Bl5UPyMwV4zn+ncV2VIVVUU7Sm3pKpITc97jVsTJEHnQqrp00RlwCaLJclH+ pz9ZFa+lQHi4eiGHSF/np5IctmVO9+LfzTE40K/WttL3CVzJTl3ahNf0QcncxwohaCksRDm6R eR714XQIqmLaq11IfgPLMR2Zs7EI/PaRcPcdE7jSu8LTWqeSrokgwDMpffVWt9c6HzcbD7GVb OaHtxcSe9n8zWpW9a5h8ubDSq6/9JU8HW3j6hoUmYolSfUAShHG4HLpsgLERW9tXRHQbhSpuG LdPahFc1NlTHsCJkF2H32oQGrPeDvDztZSf6NAiz0PBm16764hefoCJDz4pQnhG4Iax3Z2MlL k7EiQtzQSWS5yy21FTKfAP4URaXToi3bF5vQaKm/6cIZhRZf4R2SGln4UJJJgPC1n7xcWB8+y OVWBKKlcz8YR75exbmCre6S311UmX65EdL//2BOV3wyibdQ4T7ZvKyT0G4Z1kbKR9/nibrwLh XoDx19tDw/cZJl7aYdPolGBO3aR6ReAYKSf0WEKXPnIxkLI5nLLvzMd8gsei38FmSWfbI488r 03MLgKUU/v1eoECdhBykNHVkG8Wxveq9HEvh2EhZqduHIumbsY9b4fjdqRy6DCEcFXX3kpZcw o5SjhdA8Eh2iCiNCob4y1dOJPYnW0M52byEP5qCUwNC4f3fg+mG6EqX5Wm4QBQ6kRtMg4W8W0 kAHl0eKAipDbuwNf19tjlItykZ7WD6b26d/zv0OH1JUVxsjF3KEfB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Two function calls were combined in this function implementation. >> Inline corresponding code so that extra error checks can be avoided her= e. > > I don't see any point to this at all. Would you like to take another look at corresponding design options? How do you think about to check run time characteristics any more? > By inlining the code, you have created a clone, > which will introduce extra work to maintain in the future. Would you find the shown software transformation acceptable if a C compiler will be able to generate a similar code structure? Regards, Markus