Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp794605ybi; Sat, 15 Jun 2019 11:53:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqysU0iLGd7JwVikOdljUfz266Z0fYJ7eDYzsnLtYx2IRy+pvUZbPmriPh/WQjsOVJSeVRQ4 X-Received: by 2002:a17:90a:de0e:: with SMTP id m14mr17546361pjv.36.1560624838223; Sat, 15 Jun 2019 11:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560624838; cv=none; d=google.com; s=arc-20160816; b=U3r/n27J9+cV0Q0LVhOOhjDlgw+JcQKTbMWA+BEWjATNfZzODTQNHN+A656F/78Pet emwVD27Ep8Mmx4QQpOTumnEDXAphX6Dc8bYcnpkk3OoSKrZeMLZfftiOD/rGBkbG3nqT AVMKTMvlkI1BfenDmhm2yg7eUd4gqrOQdK9THH//L2YsnVi1Bj22gf597SgPWttkjURC nEYbT0zKNKK37OXOgRarBHXbnhWJapKeL5U4BDaoMyLUkU5Ro3GxOwr1F+7xF6tDXPAy dK4Cd9RUmxYuDj5TTHGnTlSnkgqgUJEgwOi66F0cz6Z39lEX4B6czBYA0GvytvMiAKyo KaEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zbwW2pcyKRmZXvewdkIm3ZZlXocp8p2pjFV1vilsNhg=; b=zsmhQSxkBExNjtFUSwZapG+J65/QBooGSFOrywyskbd167v18xiUMJNLHGOfu72Rqc bCBauNEqG1SJN/Q02pnBxib3Fc/BlscS/WjLfuERU48hVnJ+AAJIkJFRwam6nXTu2PfJ zsF9WtG2FIiVChbguv9YYlf/Ih2FIgLFJsXUDoBHKxweX5R+0PK2+8LH3hinYZrFil3x gtErn1IGY5QVT/BUuzuoGZpKbaZ7hN/rmM9oyfZPHW9iHLq5G3XB7CasWlM7YN7fM3Db rhWammuy3TqymWGj94HnAzF5IU42MusxwfqnuASaNwGU1IFzNlsfr5whSk+kHqhclbfK Cv0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MR90KTxq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x24si5356336pjq.96.2019.06.15.11.53.43; Sat, 15 Jun 2019 11:53:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MR90KTxq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727056AbfFOSwh (ORCPT + 99 others); Sat, 15 Jun 2019 14:52:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:40704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfFOSwh (ORCPT ); Sat, 15 Jun 2019 14:52:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 374B821841; Sat, 15 Jun 2019 18:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560624756; bh=M99q4/HQ+4Y/74fnc/bD3P3M1u3ivtN+4HrYjppkzAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MR90KTxqd2IppmmAO3/oulKkVOC4tLchGohQ7VIOQVtw4+rGYTo14eJvgueeoCN/A Gs/wHIJQM+UbsSVFlFjqr0hwRwIVPsWZHvGKuud+C9YP8qC3zjTruWaj50JD3Pphek 661SnPj8GVZqbTLVsxR6xh3yU7oqp8i2Fwrc2WPY= Date: Sat, 15 Jun 2019 20:52:34 +0200 From: Greg Kroah-Hartman To: Hariprasad Kelam Cc: Josenivaldo Benito Jr , Himadri Pandya , Larry Finger , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: hal: Remove return type of initrecvbuf Message-ID: <20190615185234.GB10201@kroah.com> References: <20190615172220.GA6344@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190615172220.GA6344@hari-Inspiron-1545> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 15, 2019 at 10:52:20PM +0530, Hariprasad Kelam wrote: > change return of initrecvbuf from s32 to void. As this function always > returns SUCCESS . > > fix checkpatch warning "Comparison to false is error prone" That is doing multiple things in the same patch, please break this up :(