Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp869961ybi; Sat, 15 Jun 2019 13:45:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqyzRmWVaob8/nJPzQ6LvEU84vQc80IlpHh9FEsWHvTwncmJyUDXde25mNDvxfhT91QGE2ei X-Received: by 2002:a17:90a:24e4:: with SMTP id i91mr18647432pje.9.1560631544335; Sat, 15 Jun 2019 13:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560631544; cv=none; d=google.com; s=arc-20160816; b=fPqgJ07cwupGd2pdim6wxRyN7tFLlNU5ioxgD87aiz/GDbhN+VgaEyrZZtPpPZxGQA p21gGMvp83PA/AKzI7RWPDfKK10ZdPxJoWj2zCqs7xuXdSzshqOgRVNNk5T200ZKu2fv 2M8RUPZ5mr8T1QOPIOLGKLqkofxe+UEL5MelRc+WCu6fyZV+ivmqX+b+CCRwt4iA75yj v0UJnQ/Il3O1teiXcxsQtWbFlqPAMbvuEXoTp6BCh/ytMpom/m2EXrow8QI9oT2qCd5g DHZyYVuVTDSLlyFYdB3xlS2naGQ4TpHkECBiHyC6HDk7Kk2dbTrf2j5/2k1tBWqVG37M ZL8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hHldrhavHTlgFRy4w9wfT59ztwkn2NOf4LNTIY/lF/Y=; b=Q4BjCmVm2U0AiMZbMk7mnXo+vSQJTRuPeP6y0NfYY6sMDsY37Ie5Xnxal5GZskvBgx 2CL6EKB0wzRASBvdFXpsTbqisV9u7wWC+65Q/YcQFK0kfMAEr20NZOKa/nZDs+PGJ6kP Eaeb+zotNWN/O5kmPJvbkwWVAYk9PQW226qg4WsMZ1bJxP4BNCDOhFuJTokqmDKaAfDF i+PWpAAqC/y8Ujmx/j/netwLOY7AYAOKIUQaMxfFEOLOY/LHMY2KtmP5GZGT0uKiJoy2 Q3WlW/jrwyMG0tnTX26uVKVB7RLFYyd0Z/wgJXd0M3jE7H+HWj4GSx36118AgpyjnaPN dlSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o188si5784010pfo.219.2019.06.15.13.45.28; Sat, 15 Jun 2019 13:45:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726917AbfFOUnb (ORCPT + 99 others); Sat, 15 Jun 2019 16:43:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43226 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbfFOUnb (ORCPT ); Sat, 15 Jun 2019 16:43:31 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 108A13083391; Sat, 15 Jun 2019 20:43:31 +0000 (UTC) Received: from treble (ovpn-112-16.rdu2.redhat.com [10.10.112.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 044F660CA3; Sat, 15 Jun 2019 20:43:24 +0000 (UTC) Date: Sat, 15 Jun 2019 15:43:20 -0500 From: Josh Poimboeuf To: Miroslav Benes Cc: jikos@kernel.org, pmladek@suse.com, joe.lawrence@redhat.com, kamalesh@linux.vnet.ibm.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v4 0/3] livepatch: Cleanup of reliable stacktrace warnings Message-ID: <20190615204320.i4qxbk2m3ee73vyg@treble> References: <20190611141320.25359-1-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190611141320.25359-1-mbenes@suse.cz> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Sat, 15 Jun 2019 20:43:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 04:13:17PM +0200, Miroslav Benes wrote: > This is the fourth attempt to improve the situation of reliable stack > trace warnings in livepatch. Based on discussion in > 20190531074147.27616-1-pmladek@suse.com (v3). > > Changes against v3: > + weak save_stack_trace_tsk_reliable() removed, because it is not needed > anymore thanks to Thomas' recent improvements > + klp_have_reliable_stack() check reintroduced in klp_try_switch_task() > > Changes against v2: > > + Put back the patch removing WARN_ONCE in the weak > save_stack_trace_tsk_reliable(). It is related. > + Simplified patch removing the duplicate warning from klp_check_stack() > + Update commit message for 3rd patch [Josh] > > Miroslav Benes (2): > stacktrace: Remove weak version of save_stack_trace_tsk_reliable() > Revert "livepatch: Remove reliable stacktrace check in > klp_try_switch_task()" > > Petr Mladek (1): > livepatch: Remove duplicate warning about missing reliable stacktrace > support > > kernel/livepatch/transition.c | 8 +++++++- > kernel/stacktrace.c | 8 -------- > 2 files changed, 7 insertions(+), 9 deletions(-) Thanks Miroslav for wrapping this up, and thanks to Petr for his previous work on this. Acked-by: Josh Poimboeuf -- Josh