Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190614230821.3146272-1-ast@kernel.org>
In-Reply-To: <20190614230821.3146272-1-ast@kernel.org>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Sat, 15 Jun 2019 14:46:03 -0700
Message-ID: <CAADnVQK2Nq6_HQT7Opn1XkA7s6UteVE_qOpXq8AiQwFOmeB6jA@mail.gmail.com>
Subject: Re: [PATCH bpf] bpf, x64: fix stack layout of JITed bpf code
To:     Alexei Starovoitov <ast@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Daniel Borkmann <daniel@iogearbox.net>,
        X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 14, 2019 at 4:10 PM Alexei Starovoitov <ast@kernel.org> wrote:
>
> Since commit 177366bf7ceb the %rbp stopped pointing to %rbp of the
> previous stack frame. That broke frame pointer based stack unwinding.
> This commit is a partial revert of it.
> Note that the location of tail_call_cnt is fixed, since the verifier
> enforces MAX_BPF_STACK stack size for programs with tail calls.
>
> Fixes: 177366bf7ceb ("bpf: change x86 JITed program stack layout")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

Applied to bpf tree.