Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1105305ybi; Sat, 15 Jun 2019 20:35:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxlqT35PzJUPwwYxJgb2jbRo/z8a/N2ehORVRIYAMF3+MU92RuM1lkx8K081EtPZ+uxaAlc X-Received: by 2002:a62:ae01:: with SMTP id q1mr51355096pff.219.1560656153789; Sat, 15 Jun 2019 20:35:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560656153; cv=none; d=google.com; s=arc-20160816; b=NdsWyqLR8QpVmt5gnIQNNOFj6fF4gD0SAB3EuYecGHv/DVwPkApYudbVIvi6MztEg7 uFqDvlSxCdPu6dl9loEZKtq4dkME4EI3ItgkmEvgX162XLu9fxIhD6Qx29y/mN8fDj7E VE4KN9tyMcpyq6eTFAQjYOoGGc1rFwvwbi2GLYfwVL8Esiikt5tiO0HRXZ3tTeihMlVt a4HwzziFzHknRT0Qq2SRcdArvW9ENDqUNuOqXIDoGlcKhWsMZJgqsa8JlSGNVwjzLVhw DR9oBNN2GX7ZqLYUARcnzbKleNoaIh68tkSlpp1AOqYqJLpHBP3Auc/ouSZNIgQEXHyC WrCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature; bh=P+dZfWhhczsv5TTRUbrSlNE3547rfcjOFelTNKUKczI=; b=JMbPo4gubCNBJuXgMk125G1773u9a2g1b12745dTLd4T+3Nb9D2bFAljl1lWcKMaim jHIR7M9UfJcT85cOaVWGM246kh4QD41bpZF5RnRtHwpVzlgYcyEQUe9UQukBcnkK/dfw Qq7VSfHg6jPABPtEMgJiS/jZLOSi1v1DR+tjGY8vf6SZi982wjiqa9gJJ+QRPOBHVbr6 4BoYUEZqIhqI9x2l1hLw4nhxgEO0d4isWbeSwuUep9xdJszheEJW+TJ+7SKt+bSqzaCx kLtd2BtPfgopO5+IhNi850jws4+cwBy+L4aJGbtSycu4vMSAFZi143tEo9+NQvvbvGPU coSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SJq9+4xU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t6si6140942plr.245.2019.06.15.20.35.37; Sat, 15 Jun 2019 20:35:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SJq9+4xU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbfFPDfe (ORCPT + 99 others); Sat, 15 Jun 2019 23:35:34 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:41422 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbfFPDfe (ORCPT ); Sat, 15 Jun 2019 23:35:34 -0400 Received: by mail-pf1-f193.google.com with SMTP id m30so3756213pff.8 for ; Sat, 15 Jun 2019 20:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=P+dZfWhhczsv5TTRUbrSlNE3547rfcjOFelTNKUKczI=; b=SJq9+4xUablqDSXRTAq0ercysLl4BrTt8Wr2v4V+ZitlX+vGwokkg1PBXq28Ib7C3F 7jpzuvr2lhhWoruFFoSOKhrw08dLdumrTA0bEkKkIqRHT/OMx7bPHi2X40UryG+12fVM 1O4CSlDx/MNDO0QZVaKHz0h17gc/NwMgvJF43I8bu3GWv3kxpcGUjM4f64Uv3uIrdnew 5O9iao2Yi7etmG3zEYgrdLkyY2hlvodEQ1BRgUyxf4bR86kGSgYuWv0g1XlSX9wUTsVW 5Afxt2Js165Qgx6FPJS2CW1Tb8k30p6bdklfqZ9iEnrYfcOU7ATHqkFcDg/XiG1HONnz zDdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=P+dZfWhhczsv5TTRUbrSlNE3547rfcjOFelTNKUKczI=; b=ND63oJB5Rlmb3RpQkTN78mAUvx+KlkDzRUq/txxY5kYevT71P2n3wonp0+Ss73WXmp l/94yXIV+ZvEfc9QLa21gaAQ1HvTD5Ys2ZbCCl09CQzosgOGyJiF39A3P3lfixjxVPwp 16A8nWH7TWmEnr7xz0CI+7JWbQn2DE9KIyFKNLM3GiBOCpi0JhwhnILejMbtBpoVinqu 4YKnA77HgNguH6SiPoRgW4uT3lsdEGimQ4GUPYjDFUfi+qSiJDrsYJNv/DLcxw35fWFV UMI9FewvZkUKAj2+oFTJJCaaSwLRSixeyXn2UaXgGQ4y+k5Y4+Xb2iVdCN+LyNDcdaht L+mw== X-Gm-Message-State: APjAAAWP0jGXhrKsy3G5TN2QtvUlfDhPvk683byRghX6/XPrgcsEdSp3 pUA9o3BsU5lTPt2zgOpKKVo= X-Received: by 2002:a17:90a:480d:: with SMTP id a13mr18548872pjh.40.1560656133623; Sat, 15 Jun 2019 20:35:33 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.89.153]) by smtp.gmail.com with ESMTPSA id g6sm7318314pgh.64.2019.06.15.20.35.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 20:35:32 -0700 (PDT) Date: Sun, 16 Jun 2019 09:05:27 +0530 From: Hariprasad Kelam To: Greg Kroah-Hartman , Hariprasad Kelam , Kimberly Brown , Shobhit Kukreti , Bastien Nocera , Anirudh Rayabharam , Nishka Dasgupta , Hardik Singh Rathore , Mamta Shukla , Puranjay Mohan , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging/rtl8723bs/core/rtw_ap: Remove redundant call to memset Message-ID: <20190616033527.GA14062@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtw_zmalloc is internally doing memset . So there is no need to call memset again. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 87b201a..df055b8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -1502,8 +1502,6 @@ static int rtw_ap_set_key( goto exit; } - memset(psetkeyparm, 0, sizeof(struct setkey_parm)); - psetkeyparm->keyid = (u8)keyid; if (is_wep_enc(alg)) padapter->securitypriv.key_mask |= BIT(psetkeyparm->keyid); -- 2.7.4