Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1235946ybi; Sun, 16 Jun 2019 00:14:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYPBorvSfrVGqSwU4kgKJJ6YXP5EnBxayX5wWMrW7+S1tOc0TWnYMswBMn43mPb3IVATKI X-Received: by 2002:a62:ce07:: with SMTP id y7mr78183050pfg.12.1560669298544; Sun, 16 Jun 2019 00:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560669298; cv=none; d=google.com; s=arc-20160816; b=TDh4PS54xIAILVinVmeyeoFBUk+Ag9tO10wbzCP0IgogQKllfS7RXxlcWZ8T3ZQoyG tdvPt5IFRWKfL9tpNolHO4pnsBWHPc1RbUvEbbbxygX1Dp69Uc84RoVdAgVEyQ+qBdb3 6vLRHuZdoWocxdZSNPQXQC+dCCCWAtytpPJxgpfSmhTftRoU/doMx4AkU52kdo5STgzu zXb6MxeGne+78IrbrVjCA0EGUA/tTy8Iy1ceTMQ+8q1+S++XFaVNivmfjGHwz5Iy+wBH 9DDxOvYjncyobEvxEPC3iDlXu4a5NuUTdZBp2LjTbtcA6IrT5DkLs5RTM9CrDhb9fI76 fDEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=8aRuqwL/ZwGa/nAFi+3X3Sar/jkAlcYGZXRFf14/gYw=; b=NAgiuchpzb4LPO1sid3ji5tPch0fe/lLF6qnrRHXdCvBD0KvfrFA8rp8nw4uXgU0ae ogXZlbGEleUk8j/7fXNCqUBeqp2FPHs9fYIH/VJWqJhjNfs7jBYVY13QRrOdietTXaSH xL/4I+nSa5+UK5eS934+qAob+KATz4nXlFP4Zy8sHFsecgQtShbo5Yj8w1rJkgU8pBC3 1V5lE7di9lA7Y02jL31Pui+yaN27m1NoB4JAIwZ9i0L1cOfrh/BSDd6w9ii9s/nX/mpa nzBqK11ydYTYBmMR1XHr7BLqumOyQNr2eUECmi12cbxodnuIkIMTvbAA8rB2xfuoTKNW dVfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si7200298pgt.217.2019.06.16.00.14.43; Sun, 16 Jun 2019 00:14:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbfFPHO0 (ORCPT + 99 others); Sun, 16 Jun 2019 03:14:26 -0400 Received: from mail5.windriver.com ([192.103.53.11]:58148 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbfFPHOZ (ORCPT ); Sun, 16 Jun 2019 03:14:25 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id x5G7CC6u031011 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 16 Jun 2019 00:12:27 -0700 Received: from [128.224.155.90] (128.224.155.90) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 00:12:06 -0700 Subject: Re: memory leak in tipc_buf_acquire To: Xin Long , syzbot CC: davem , Jon Maloy , LKML , network dev , syzkaller-bugs , References: <000000000000000c060589a8bc66@google.com> From: Ying Xue Message-ID: Date: Sun, 16 Jun 2019 15:02:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.155.90] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/10/19 2:44 AM, Xin Long wrote: > Looks we need to purge each member's deferredq list in tipc_group_delete(): > diff --git a/net/tipc/group.c b/net/tipc/group.c > index 992be61..23823eb 100644 > --- a/net/tipc/group.c > +++ b/net/tipc/group.c > @@ -218,6 +218,7 @@ void tipc_group_delete(struct net *net, struct > tipc_group *grp) > > rbtree_postorder_for_each_entry_safe(m, tmp, tree, tree_node) { > tipc_group_proto_xmit(grp, m, GRP_LEAVE_MSG, &xmitq); > + __skb_queue_purge(&m->deferredq); > list_del(&m->list); > kfree(m); > } Good catch! I agree with you.