Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1363555ybi; Sun, 16 Jun 2019 03:22:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfraGDbpS6eytijXs4VnqDgDoYIdDdrlP7TURo4UXkD2NrT8T26uCYpRL6RlJV5+IUAm+R X-Received: by 2002:a65:508b:: with SMTP id r11mr13288665pgp.387.1560680533524; Sun, 16 Jun 2019 03:22:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560680533; cv=none; d=google.com; s=arc-20160816; b=gomv70qQG+C4LvjYSjyZJyAY7wGSEtwipH2GDJEJUZUf5XtYjhDYQkDO+yajrujWSs kpFVTGsIB49FnaU1J0A/w433B4vZv2JRY1Kw8UBS15L4mMo6iFQE+b86YVvFGwY1PTir 0dsK3w5TR1UUz0y0XchVkhZ9HqpzPbF5rdJrAmGf4WAc2hg9Inyr4GWR0Le1JAVBk4z6 dDErF3+Vlmpm4obLuet98Q1sgpuSDL0O4onX65vaIQKG5YXsEnOPfCEhPivJBhWqKpau yPHVGDV+p0XL07ZVamxU4kKfCVPPq2KE1oWaNT6egAK2pviCu3Pwbq4qnm5B7LsuTlh9 im7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9RwPC+CEHLL3tapiiGqa1b1Km+/F+a1bnH2Wq6U6V4A=; b=UACGDxB8xI80m6kO5msU9Gga3NciZKxnEeSNUniwaH6Qkdk/MuknBSS/qxMJvKllIf nLjgnVIPQFB2nqXLyQ6qi3jVKLgsX46+JX90V/AfisZ3SDaHDorr9bA3l8iXqOxK40D1 rJRFpr3StgyYN4Ap7Znxtt2EOVmExTZ4yrYqgO/4IIsVCNyud5T9eFQOz5WzGOwgBaBU sn4NUN7GrHz8koMh9ah+1w1Nse+VzM5sgU0vPKJj3InrTWWA12txO5hac9aL8EMBuot2 4XeSqCaWd+DRQB11r7iggTlHuRKBTY+ymLaJ4gYDypbqcoyEwXxFpTVBMkFH8bTXe7gI qkDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XJaNAmw7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si8237717pgg.386.2019.06.16.03.21.58; Sun, 16 Jun 2019 03:22:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XJaNAmw7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbfFPKUW (ORCPT + 99 others); Sun, 16 Jun 2019 06:20:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:34342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbfFPKUV (ORCPT ); Sun, 16 Jun 2019 06:20:21 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE5A32084A; Sun, 16 Jun 2019 10:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560680421; bh=iBkYP6OfU54csm2E37SPikvbgfpw7ys0HbRZX4qW+4Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XJaNAmw7TcK41st5yYw2e9/EQXxLNabrPusfr6OOr9IirDY08R9Fg3/woo3emkSGk XPFAOaaJY42wcMGK4EMopx1wNIq7rHb87fPRNsU0BKzJOHV/lkPjY8bB0rGiu7y+Ee qHxOnKLhFqm6JQrtyr+wEC90HaKwFber3V+EsyVE= Date: Sun, 16 Jun 2019 11:20:14 +0100 From: Jonathan Cameron To: Melissa Wen Cc: Lars-Peter Clausen , Michael Hennerich , Stefan Popa , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Barry Song <21cnbao@gmail.com>, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: Re: [PATCH v2 3/3] staging: iio: ad7150: clean up of comments Message-ID: <20190616112014.1010b145@archlinux> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jun 2019 13:33:19 -0300 Melissa Wen wrote: > General cleaning of comments to remove useless information or improve > description. > > Signed-off-by: Melissa Wen Applied, Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 7d56f10a19ed..51d6b52bce8b 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -163,7 +163,8 @@ static int ad7150_read_event_config(struct iio_dev *indio_dev, > return -EINVAL; > } > > -/* lock should be held */ > +/* state_lock should be held to ensure consistent state*/ > + > static int ad7150_write_event_params(struct iio_dev *indio_dev, > unsigned int chan, > enum iio_event_type type, > @@ -479,10 +480,6 @@ static const struct iio_chan_spec ad7150_channels[] = { > AD7150_CAPACITANCE_CHAN(1) > }; > > -/* > - * threshold events > - */ > - > static irqreturn_t ad7150_event_handler(int irq, void *private) > { > struct iio_dev *indio_dev = private; > @@ -571,10 +568,6 @@ static const struct iio_info ad7150_info = { > .write_event_value = &ad7150_write_event_value, > }; > > -/* > - * device probe and remove > - */ > - > static int ad7150_probe(struct i2c_client *client, > const struct i2c_device_id *id) > {