Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 17 Jun 2019 09:21:04 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Weikang shi <swkhack@gmail.com>
cc:     John Stultz <john.stultz@linaro.org>, sboyd@kernel.org,
        LKML <linux-kernel@vger.kernel.org>, swkhack@qq.com,
        Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: [PATCH] time: fix a assignment error in ntp module
In-Reply-To: <20190422093421.47896-1-swkhack@gmail.com>
Message-ID: <alpine.DEB.2.21.1906170814590.1760@nanos.tec.linutronix.de>
References: <20190422093421.47896-1-swkhack@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 22 Apr 2019, Weikang shi wrote:

> From: swkhack <swkhack@gmail.com>
> 
> It is meanless to check a 64bit(txc->constant) value is postive 
> when the value has to be assigned to a 32 bit variable(*time_tai).
> So I make a temp type conversion before the compare.

What? Casting it to int makes it more negative, right?

That's just wrong:

       long long x = 0xFFFFFFFF00000000;
       int y = (int) x;

x is obviously negative, but y not. C type casting 101.

> Signed-off-by: swkhack <swkhack@gmail.com>
> ---
>  kernel/time/ntp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
> index 92a90014a..6b454eafc 100644
> --- a/kernel/time/ntp.c
> +++ b/kernel/time/ntp.c
> @@ -690,7 +690,7 @@ static inline void process_adjtimex_modes(const struct __kernel_timex *txc,
>  		time_constant = max(time_constant, 0l);
>  	}
>  
> -	if (txc->modes & ADJ_TAI && txc->constant > 0)
> +	if (txc->modes & ADJ_TAI && (int)txc->constant > 0)
>  		*time_tai = txc->constant;

The way more interesting question is whether txc->constant can be >
UINT_MAX. In that case the txc->constant would be truncated.

Miroslav?

Thanks,

	tglx