Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] coresight: replicator: Add terminate entry for
 acpi_device_id tables
To:     weiyongjun1@huawei.com, mathieu.poirier@linaro.org,
        alexander.shishkin@linux.intel.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <20190615104440.94149-1-weiyongjun1@huawei.com>
From:   Suzuki K Poulose <suzuki.poulose@arm.com>
Message-ID: <06c751dc-0a23-b33b-1ff1-a98d6503408c@arm.com>
Date:   Mon, 17 Jun 2019 09:25:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190615104440.94149-1-weiyongjun1@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

Thanks for the fix, please find my comment below.

On 15/06/2019 11:44, Wei Yongjun wrote:
> Make sure acpi_device_id tables have terminate entry.
> 
> Fixes: 8f35caae1e1f ("coresight: acpi: Support for platform devices")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>   drivers/hwtracing/coresight/coresight-replicator.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 542952759941..0c73dc1073c0 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
>   #ifdef CONFIG_ACPI
>   static const struct acpi_device_id static_replicator_acpi_ids[] = {
>   	{"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
> +	{"", 0},

nit: I would leave it {}, instead of creating an empty string.

With that :

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>