Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932508AbVKWETe (ORCPT ); Tue, 22 Nov 2005 23:19:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932510AbVKWETe (ORCPT ); Tue, 22 Nov 2005 23:19:34 -0500 Received: from mx1.redhat.com ([66.187.233.31]:12978 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932508AbVKWETd (ORCPT ); Tue, 22 Nov 2005 23:19:33 -0500 Date: Tue, 22 Nov 2005 23:19:17 -0500 From: Dave Jones To: gcoady@gmail.com Cc: Andrew Morton , Greg KH , david.fox@linspire.com, linux-kernel@vger.kernel.org Subject: Re: 2.6.15-rc2 pci_ids.h cleanup is a pain Message-ID: <20051123041917.GA27358@redhat.com> Mail-Followup-To: Dave Jones , gcoady@gmail.com, Andrew Morton , Greg KH , david.fox@linspire.com, linux-kernel@vger.kernel.org References: <438249CB.8050200@linspire.com> <20051121224438.GA18966@kroah.com> <20051122162558.702fae4a.akpm@osdl.org> <41i7o11nbvrfrd8n2ev6kf11qjfjbil3jr@4ax.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41i7o11nbvrfrd8n2ev6kf11qjfjbil3jr@4ax.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 38 On Wed, Nov 23, 2005 at 12:51:45PM +1100, Grant Coady wrote: > Hi Andrew, Greg, > > On Tue, 22 Nov 2005 16:25:58 -0800, Andrew Morton wrote: > > >Greg KH wrote: > >> > >> On Mon, Nov 21, 2005 at 02:27:23PM -0800, David Fox wrote: > >> > I'm sure I'm not the only person that applies patches to the kernel that > >> > use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I > >> > would like to see the PCI ids that were removed simply because the don't > >> > occur in the main kernel source restored. Is there a rationale for > >> > removing them that I'm not aware of? > >> > >> They were not being used. Why would you want them in there? > > > >Because they contained useful information which had been accumulated by > >many people over a long period of time. > > > >Throwing that information away seemed rather pointless, especially as the > >cost of retaining it was so low. > > There's an out-of-tree reference, the pci.ids website, that carries > this information, do we need the reference info in the kernel as well? > > So far two people raised an objection, the other wants to maintain > an out-of-tree driver, D. Fox didn't say why he needs the symbols. Three. I already mentioned we broke the compilation of the advansys driver because of this. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/