Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2418319ybi; Mon, 17 Jun 2019 04:35:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6ue6HjOz3T0tFiBJbEPIlJ1qMyvcYobYvabm7R5hfv2avcJ1KllymcZDHZ4dROXp2d0Fk X-Received: by 2002:a65:5945:: with SMTP id g5mr16162680pgu.169.1560771324977; Mon, 17 Jun 2019 04:35:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560771324; cv=none; d=google.com; s=arc-20160816; b=NYoldPPVFnsXTr3C3G9Bque3WXwt26IRNzlM5HW3w5sbAWFJw/H3r1ILrNVXeyDPi4 vxgQrMFdVO4c56ukBSoCJSwocZYWoIFq2AEn0/MF4+wB2gkmmkRH+qr34Grf59ZR0w46 lXnAUYGHUVKaGS/b2NonT5iESyjVG2hlnPw9Lr98V6xuIC/j88bUYszHcOO4/ESMWFVZ tRIcEYktWim2ZYBdQd4n7SfdDKVzpZMtb8bAzvaHvFNVY48QXhlzvgokMTH6S2cECk/7 rheNfTkCyTCIV0/tvNoiRHU45J8lPoJsL5Ru3TM5jpzMdXiUci5r9HdYQa4o/ga3Z7nZ IQgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+UscEGjptaRqV9EzmMNBitafCpuDk/WBqJgsaMVzMCY=; b=igIdsk+bjg2kpVJ2h6yicDE9pBXauWPEP80Mnv45HgmnTTdkKfOpSjYKtgJxKP1JrA PAnIt4JltKMhCVNrUzCwMBa6uiFvNVU/DeIrPV76mvVae3qeD5OERXsUmtd3rpJwrTDV UGaWXslLllKta678kXFI2j3pPz8wmLQ7nEgfNV5K7QlOLKwmfdw76TwpsniLlb5uBXp2 Imlt8jiPIZ1TguQJ880szC8fWUdqoU9hF09SWJx2utKc/aTJpDfi5ExwOQcbB+YGNf39 Lcd6YltGy1jQljoKtWHAU/+ebcO9c/08JsXUPC5ac0QNHfc9EDbkrx7/ZUiqCPCLaMUF ulPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i23si10710107pgh.26.2019.06.17.04.35.09; Mon, 17 Jun 2019 04:35:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbfFQLey (ORCPT + 99 others); Mon, 17 Jun 2019 07:34:54 -0400 Received: from mga12.intel.com ([192.55.52.136]:54390 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbfFQLev (ORCPT ); Mon, 17 Jun 2019 07:34:51 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 04:34:51 -0700 X-ExtLoop1: 1 Received: from xxx.igk.intel.com ([10.237.93.170]) by fmsmga006.fm.intel.com with ESMTP; 17 Jun 2019 04:34:49 -0700 From: =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= To: alsa-devel@alsa-project.org Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Pierre-Louis Bossart , Jie Yang , Cezary Rojewski , linux-kernel@vger.kernel.org, =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= Subject: [PATCH v2 00/11] Fix driver reload issues Date: Mon, 17 Jun 2019 13:36:33 +0200 Message-Id: <20190617113644.25621-1-amadeuszx.slawinski@linux.intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This series of patches introduces fixes to various issues found while trying to unload all snd* modules and then loading them again. This allows for modules to be really _modules_ and be unloaded and loaded on demand, making it easier to develop and test them without constant system reboots. There are some fixes in flow, either we don't initialize things before cleaning them up, clean up in wrong places or don't clean up at all. Other patches fix memory management problems, mostly things are not being freed. And finally there is few miscellaneous patches, please refer to specific patches to see what they do. This series was tested on SKL, BXT, GLK & KBL. Changes from previous patchset: * followed suggetion by Pierre in "ALSA: hdac: Fix codec name after machine driver is unloaded and reloaded" * dropped patches which were merged Amadeusz Sławiński (11): ASoC: Intel: Skylake: Initialize lists before access so they are safe to use ALSA: hdac: Fix codec name after machine driver is unloaded and reloaded ASoC: compress: Fix memory leak from snd_soc_new_compress ASoC: Intel: Skylake: Don't return failure on machine driver reload ASoC: Intel: Skylake: Remove static table index when parsing topology ASoC: Intel: Skylake: Add function to cleanup debugfs interface ASoC: Intel: Skylake: Properly cleanup on component removal ASoC: Intel: Skylake: Fix NULL ptr dereference when unloading clk dev ASoC: Intel: hdac_hdmi: Set ops to NULL on remove ASoC: topology: Consolidate how dtexts and dvalues are freed ASoC: topology: Consolidate and fix asoc_tplg_dapm_widget_*_create flow sound/hda/ext/hdac_ext_bus.c | 8 +- sound/soc/codecs/hdac_hdmi.c | 6 ++ sound/soc/intel/skylake/skl-debug.c | 9 ++ sound/soc/intel/skylake/skl-pcm.c | 16 ++-- sound/soc/intel/skylake/skl-ssp-clk.c | 16 ++-- sound/soc/intel/skylake/skl-topology.c | 50 ++++++----- sound/soc/intel/skylake/skl-topology.h | 2 + sound/soc/intel/skylake/skl.c | 7 +- sound/soc/intel/skylake/skl.h | 5 ++ sound/soc/soc-compress.c | 17 ++-- sound/soc/soc-topology.c | 114 ++++++++++++------------- 11 files changed, 136 insertions(+), 114 deletions(-) -- 2.17.1