Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 17 Jun 2019 14:14:57 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     =?GB2312?B?zqy/tcqv?= <swkhack@gmail.com>
cc:     John Stultz <john.stultz@linaro.org>, sboyd@kernel.org,
        LKML <linux-kernel@vger.kernel.org>, swkhack@qq.com,
        Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: [PATCH] time: fix a assignment error in ntp module
In-Reply-To: <CAObeVcdBDbSiyQCX7C_G3p6TpB9yjRyrWwsvPgh11V8v+BNaqQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.1906171409250.1854@nanos.tec.linutronix.de>
References: <20190422093421.47896-1-swkhack@gmail.com> <alpine.DEB.2.21.1906170814590.1760@nanos.tec.linutronix.de> <CAObeVcdBDbSiyQCX7C_G3p6TpB9yjRyrWwsvPgh11V8v+BNaqQ@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-426885459-1560773698=:1854"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-426885459-1560773698=:1854
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 17 Jun 2019, 维康石 wrote:

  A: Because it messes up the order in which people normally read text.
  Q: Why is top-posting such a bad thing?
  A: Top-posting.
  Q: What is the most annoying thing in e-mail?

  A: No.
  Q: Should I include quotations after my reply?

  http://daringfireball.net/2007/07/on_top

> Yes,the  >UINT_MAX value can be passed by
> syscall adjtimex->do_adjtimex->__do_adjtimex->process_adjtimex_modes by the
> proper arugments.

So there is clearly some sanity check missing, but surely not that
type cast.

> > > -     if (txc->modes & ADJ_TAI && txc->constant > 0)
> > > +     if (txc->modes & ADJ_TAI && (int)txc->constant > 0)
> > >               *time_tai = txc->constant;
> >
> > The way more interesting question is whether txc->constant can be >
> > UINT_MAX. In that case the txc->constant would be truncated.
> >
> > Miroslav?

Thanks,

         tglx
--8323329-426885459-1560773698=:1854--