Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2510410ybi; Mon, 17 Jun 2019 06:09:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGpDlrBvyGKiVhEx/94KfGlbiBjoN3cFffZfBOIqEApi/GFI4hAVIH28LOLKPS4NEzKEmw X-Received: by 2002:a17:902:8b82:: with SMTP id ay2mr10118095plb.164.1560776992235; Mon, 17 Jun 2019 06:09:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560776992; cv=none; d=google.com; s=arc-20160816; b=V2MfRwcZHQzr+5OxMtBwBjtn3MNoI8lm16FRJYHYmEE1xfmlI4rAlSZ6q2xMrt/482 VEBXsp9LD997/62DDC5Fv1bLB39BXbmjLXzoNZEeUUmoJWo4KdKGx6IqLidrYOlKY7sh kV4dLRFtzqhCSsBWTIDacQtca4GVSMkRHU0X2Pz86Oh6SI+6ykmG48bmU5CvrboK4Wht XqlfN1+BYjKf3sxwc0v2Np6YMyt/gcQXQhH9coWh7XGLdZSO2DjEQq/pSpgqF2U3R5bE PHNssZQg80YXNZ9K8/XI7Q3TJsBSVZE0wqbmRh+CbSAjsZMRAS+2OM/KgtLK4Fkc9U6Y Ey9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hfn/DWqRUYbZiLRqNIB4Jd6pi66TIc+J30YbbACD/LM=; b=RCjDe37AzOazMB4573JlfXqL3JOjstvB1pwb4nErsOyN8+Z5k9BaiSuYHpxlqHzGC0 90ICw73Zcf9T2wLpHeIBM3oGrYHr7VW+Zz6A35sN+YtnfS8Qvimi7g+WJJZ7ZzQe6PiN GPdnEzEB/1kAerv56RdyKlV0iYeRJZDcOeq9lTk/4+flxYpNm3JAu3+v/fpnWXd6xYBN xGhEORXtsaNTRJdc1Z8n038LdtFzf8vlBWmSeo14+MI+e2sbb2jLTINbXjgHgpdeY1im 2eR1YAz1TikcEdEo3/jeSkGjrOeyhD1Z2nn8WZFXv2oAX0vji2s9ufLDJBv2DGYFyqaS 5oiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32si10231653plc.152.2019.06.17.06.09.36; Mon, 17 Jun 2019 06:09:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727703AbfFQNJZ (ORCPT + 99 others); Mon, 17 Jun 2019 09:09:25 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46051 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbfFQNJY (ORCPT ); Mon, 17 Jun 2019 09:09:24 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id B9A7E8025E; Mon, 17 Jun 2019 15:09:11 +0200 (CEST) Date: Mon, 17 Jun 2019 15:09:21 +0200 From: Pavel Machek To: Dexuan Cui Cc: Michael Kelley , "linux-acpi@vger.kernel.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "robert.moore@intel.com" , "erik.schmauss@intel.com" , Russell King , Russ Dill , Sebastian Capella , Lorenzo Pieralisi , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , KY Srinivasan , Stephen Hemminger , Haiyang Zhang , Sasha Levin , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , vkuznets , "marcelo.cerri@canonical.com" Subject: Re: [PATCH] ACPI: PM: Export the function acpi_sleep_state_supported() Message-ID: <20190617130921.GC21113@amd> References: <1560536224-35338-1-git-send-email-decui@microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="69pVuxX8awAiJ7fD" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --69pVuxX8awAiJ7fD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > It seems that sleep.c isn't built when on the ARM64 architecture. Using > > acpi_sleep_state_supported() directly in hv_balloon.c will be problemat= ic > > since hv_balloon.c needs to be architecture independent when the > > Hyper-V ARM64 support is added. If that doesn't change, a per-architec= ture > > wrapper will be needed to give hv_balloon.c the correct information. T= his > > may affect whether acpi_sleep_state_supported() needs to be exported vs. > > just removing the "static". I'm not sure what the best approach is. > >=20 > > Michael >=20 > + some ARM experts who worked on arch/arm/kernel/hibernate.c. >=20 > drivers/acpi/sleep.c is only built if ACPI_SYSTEM_POWER_STATES_SUPPORT > is defined, but it looks this option is not defined on ARM. >=20 > It looks ARM does not support the ACPI S4 state, then how do we know=20 > if an ARM host supports hibernation or not? But actually... I remember ELCE talk about hibernation or ARM32. Not sure if patches are mainline, but someone was working on that. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --69pVuxX8awAiJ7fD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl0HkQEACgkQMOfwapXb+vJUqACbBRbrUMu0nfAR+ZaWSWjQrS1t 6DEAn3UmgaE6hq2ub8ECCopo61cXUVxu =V6Tb -----END PGP SIGNATURE----- --69pVuxX8awAiJ7fD--