Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2585687ybi; Mon, 17 Jun 2019 07:16:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqyzUgF65GAZ+wOmQ1KKXgbWPRijDAS2WSP5T78+NHbHrXyBrDdMAIMMWEYSdd78q/6sRhqG X-Received: by 2002:a17:90a:9b8a:: with SMTP id g10mr25861824pjp.66.1560781004476; Mon, 17 Jun 2019 07:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560781004; cv=none; d=google.com; s=arc-20160816; b=z2CvPjX9Z5w7AkxJ+f93t+F9uWX279IrZdQYyhjgQF4834nkS12q9BEFvgiaG3VQbw YQel0VfFuzjIbfgjv165f3cFro53kJvUOPJdKRVY1Fc30gHzjHSba924Xvfi7zwsDtFH P2YjNvnXZ+G3JKWHPAwsuNd5swNr0C2X2xMHZfUActewyQ0Oe2de1OA/eym/n0xBR4Kp +S0JdvtRiwfFJKrNqH3cmtTuneExudT/FRVhistV33ePFydwAFopNfwFU+xIc27oA7Ul Xw5rmoMrAtiuAxtWsNFfqjQW78Hqjp4J87pzjWQk2wYJVn/V8h1fCVHgLDSmjLn6RxCK tGAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=JohzNFDqmktDG38rF4I6wEqhVEhI+kZN53amqkDtO9w=; b=elBosF2NRJMLki0PxhG08nl/yikUZzbG5zvhIWSx9NodH1gCdGyTvDTbHzRgrMwanI 6Liwh78W5yTBm2oknRJGfv3KuHSOCfbt5LSj83q2vQu7Mfw9erlA3MTs/kn+oikzvQ0V Pis/zQYdbtAAjZQVN9tQPrDGyHY1eVU4osgurFlGouOuxqY2e5r+hT1Lwsp7WKBDNuq3 MKj+8jCMefwv2ZqBon6pzCrHWqU1FjGMzE7UXSHwmtV70xmXGpjAG9JXrgBGJQexYA2w DJ5TR2gf6cOJIIDg0w556JsU5F45G0TlqFxoZjWiD1KXOIIB60nBO45k56ZbwiqwDyIo t9uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=iLTj9CW1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q25si11580284pfn.280.2019.06.17.07.16.28; Mon, 17 Jun 2019 07:16:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=iLTj9CW1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbfFQOO2 (ORCPT + 99 others); Mon, 17 Jun 2019 10:14:28 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:45142 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726151AbfFQOO2 (ORCPT ); Mon, 17 Jun 2019 10:14:28 -0400 Received: by mail-io1-f68.google.com with SMTP id e3so21369475ioc.12 for ; Mon, 17 Jun 2019 07:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JohzNFDqmktDG38rF4I6wEqhVEhI+kZN53amqkDtO9w=; b=iLTj9CW1lG44z6zG4g72qDio7OVGQ1qANRuf1odp+rHFRdGUwpC/crqtmZviZTJjha UtbuW0PlSUt3tPiVOOOGTLydHXo9gGuO4n6AjAd9Ui2JaV31NFPjV2LvjHM7Lc94hAj3 2NoQNsPbAu20BCZqt728HIJTa2HSnRFbDzZ5I8vHPDybVf1pkrTRlkIQTt7rthVHXrAM lHS78Ey4P/EiXWCuhSzCFdoxrAgtO7jORwoA76aPcjYfK1cFsylabCMWL2k6C+IUbYR4 GFg6aCzi53pHsNhbAN3fRtSC15Up6LfUVSf/tWR82B4diNQ+xrqBZiH+dX91u+09QU+k cDxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JohzNFDqmktDG38rF4I6wEqhVEhI+kZN53amqkDtO9w=; b=ck1o2VbyJskBr1wDeJhqaWNMJEyMJ8hGQMVxGxnX6xMDBTP9o7fFPzBXZ/IxFKNhzK 3Rhfma/2Wg6/2wpvUCHJlTdX64kSABtvHSxcEbr40rXuq+bak3VxzLRdnyQV0+4mBDIX vKUAwuRksTIPVa6ba4CP0mKmCDrNe1G9+9KPsnHPIPK9WIXjRcRLS7uwzyCOcfJmsEXZ F50qtBxEUrwMDqBzBJr+JmK60JIc/Qzx/xBK8y7x8PWCvC+Yyx69al9ikkH59nGtGd6H VVAs/d5QzjCZye7Dw09xk4L6lJkc+8SIp8lyutqvCZ0D53v3rLYneS12qkxH89HAzgQk MGLA== X-Gm-Message-State: APjAAAUOCk/I1YMBQ/qr/qZawH+Pt5ebBHbYKtxcV+VRQY+xeaTxQuv2 q3KOC4FT8P4QShC68gZO0K5ZuA== X-Received: by 2002:a6b:fb02:: with SMTP id h2mr14476535iog.289.1560780867625; Mon, 17 Jun 2019 07:14:27 -0700 (PDT) Received: from [192.168.1.196] ([216.160.37.230]) by smtp.gmail.com with ESMTPSA id c2sm8811901iok.53.2019.06.17.07.14.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 07:14:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000 From: Troy Benjegerdes In-Reply-To: Date: Mon, 17 Jun 2019 09:14:25 -0500 Cc: Andreas Schwab , Mark Rutland , devicetree@vger.kernel.org, Albert Ou , netdev@vger.kernel.org, Palmer Dabbelt , Linux Kernel Mailing List , nicolas.ferre@microchip.com, Sachin Ghadi , Yash Shah , robh+dt@kernel.org, ynezz@true.cz, linux-riscv@lists.infradead.org, davem@davemloft.net, Jim Jacobsen Content-Transfer-Encoding: quoted-printable Message-Id: References: <1560745167-9866-1-git-send-email-yash.shah@sifive.com> To: Paul Walmsley X-Mailer: Apple Mail (2.3445.9.1) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jun 17, 2019, at 6:34 AM, Paul Walmsley = wrote: >=20 > On Mon, 17 Jun 2019, Andreas Schwab wrote: >=20 >> On Jun 17 2019, Paul Walmsley wrote: >>=20 >>> On Mon, 17 Jun 2019, Andreas Schwab wrote: >>>=20 >>>> On Jun 17 2019, Paul Walmsley wrote: >>>>=20 >>>>> Looks to me that it shouldn't have an impact unless the DT string = is=20 >>>>> present, and even then, the impact might simply be that the MACB = driver=20 >>>>> may not work? >>>>=20 >>>> If the macb driver doesn't work you have an unusable system, of = course. >>>=20 >>> Why? >>=20 >> Because a system is useless without network. >=20 > =46rom an upstream Linux point of view, Yash's patches should be an=20 > improvement over the current mainline kernel situation, since there's=20= > currently no upstream support for the (SiFive-specific) TX clock = switch=20 > register. With the right DT data, and a bootloader that handles the = PHY=20 > reset, I think networking should work after his patches are upstream = --=20 > although I myself haven't tried this yet. >=20 Have we documented this tx clock switch register in something with a direct URL link (rather than a PDF)? I=E2=80=99d like to update freedom-u-sdk (or yocto) to create bootable = images with a working U-boot (upstream or not, I don=E2=80=99t care, as long as = it works), and what I have right now is the old legacy HiFive U-boot[1] and a 4.19 kernel with a bunch of extra patches. The legacy M-mode U-boot handles the phy reset already, and I=E2=80=99ve = been able to load upstream S-mode uboot as a payload via TFTP, and then=20 load and boot a 4.19 kernel.=20 It would be nice to get this all working with 5.x, however there are = still several missing pieces to really have it work well. [1] https://github.com/sifive/HiFive_U-Boot=