Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2660468ybi; Mon, 17 Jun 2019 08:28:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZoABVWMdyge4+fMyjGnygMFUkmco2rbWqP6DcpZRDxXEzAQ2mEDP3dgDCxFsLvhglX1do X-Received: by 2002:a63:3501:: with SMTP id c1mr2842571pga.115.1560785307618; Mon, 17 Jun 2019 08:28:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560785307; cv=none; d=google.com; s=arc-20160816; b=DTFxnHUjbeyZ+ZfuyhNZ6r5zH5dnR5FgHO4zQ9SAWK4aNYVfKfMvQoz1JCQlvXLI7D B0TXO7SJqg87SBPrwFG//MUNe4URxSe1ldDZYQPmAajxLxBhsD8WZx2kB24BMav3Qqdz 5fLZh/kwNFL/1r/TOfBRk4iJDvIFmx5lBeR+H++Hrd/JLDg9AGULyp3CHjbGmhShSRoU sLV5FYDO/Y5dPavHpHDk6y6zyDwAEQzUs1kIEe0en0pMYo4dJjKAPHlyMGOGnbdWH+qG 1u0cwMWv2taZRQSA2CAVQmRttJYogzvRHgn227LDEDhuHEyvcrLSsI5SpbvFCymeM8/h K2qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RODdXc2ZD5wyJFcFeho8WC0XDsY2lZXJRt8XMboVzP8=; b=vfsB1eeaH2aXIv4B5BIoYlGYhbak25Rx+uO2AaaklI0LD/oaGUW+53Tuvy0G/xQCwN qBIUNqCNGoDTsdWoPZ08pEkpIicC9jbtv1NJsTt10+U6JalJvPjHm0HrNJu0FpZbgWA1 74rgAzEQgcbjIoa7k5jHD7FYM+PeR8C1OeNzxq+nikkRHr6AEPr7tueA+2Jr5U1MwGmn 4yXoJINM9JzdIJiu7sobsgmpGQIJUH+WWl1JIvWPmN3wG3iAREbmmDPdmyuq5P3gS99x 9bGpGVKSrZ8wGp2W6inmc8ZPZEOQYLuE1qYXrQlXBTj9G+M48+LrY5rw8dCltCi3SgOZ WqKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VpHprEV3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s15si10058947pjp.38.2019.06.17.08.28.11; Mon, 17 Jun 2019 08:28:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=VpHprEV3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728145AbfFQP0o (ORCPT + 99 others); Mon, 17 Jun 2019 11:26:44 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:42820 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbfFQP0n (ORCPT ); Mon, 17 Jun 2019 11:26:43 -0400 Received: by mail-lf1-f66.google.com with SMTP id y13so6808565lfh.9; Mon, 17 Jun 2019 08:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RODdXc2ZD5wyJFcFeho8WC0XDsY2lZXJRt8XMboVzP8=; b=VpHprEV3MRqB+ioJ94x+V1DngSDAAKRmXpwiKCJYLKkHh2ryBJOXyzmgxkekOAVhS3 0DlRHF2Kr2D4rWWnerxmLuXg52Kg6NbadquKJOLB2lCKyqdH1iAbICRugQXDfsUnW+t6 /3w0t2eTstaqQfAGbQx0rBiWxRFN7SGc0LTtAP3Ys7KoLkgjxhIfawf1j0mSmnqXkwT8 dewp9gBbqYED6dr6JbWZwKU9/lGsPCDor30tZOcQC/COQKMzE10q1aZkRRxEzQug817s pp+lG9VjGrJ8N8+HlEZ55NlxuYLhBkQQoSflIi5BZ9j8prslboCA9ITnRaMSaaesXmAF 8mug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RODdXc2ZD5wyJFcFeho8WC0XDsY2lZXJRt8XMboVzP8=; b=o+IAtWGhcbKhlFuMzLnmXXqNsWh/HCWx5lKP6V/djZji+yUPiRLV0RX8HFBgjfHdxf B/IlAVqwIcf1+DpEe3mDLZquTV72GgCOCoGgdKgdt65Lf/RV37DTIuJ2VUTlJUsaOWLn /Wh318RlYFW0GESvF3B+tmZCUazsHhEHymgkyXlUqpisGbgAPdyKaJ2Oxde8RHR8EiqA X8d4EdIdvsiGEFPfS13nqQ44/rCobyB4yrJ+ShRlvHn/p+wUIltKtuTvs7os9D9tmSb4 WG818o9EN+KQj9berjACYdsLO0NIAWU47PyVBXfw7nNhohKWtYvZegZXlQnDNA1u/cer phkg== X-Gm-Message-State: APjAAAVU6LD1heOm8FLEFSWPfpxRtJySL4MKuFKOb/uEyMCOerzHzXVL meIMFuAoLB+waUX0NhOifxLKgEvc5PMvoclFjRYJYA== X-Received: by 2002:ac2:4c29:: with SMTP id u9mr2469510lfq.100.1560785201357; Mon, 17 Jun 2019 08:26:41 -0700 (PDT) MIME-Version: 1.0 References: <20190617125724.1616165-1-arnd@arndb.de> In-Reply-To: <20190617125724.1616165-1-arnd@arndb.de> From: Alexei Starovoitov Date: Mon, 17 Jun 2019 08:26:29 -0700 Message-ID: Subject: Re: [PATCH] bpf: hide do_bpf_send_signal when unused To: Arnd Bergmann Cc: Steven Rostedt , Ingo Molnar , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Yonghong Song , Martin KaFai Lau , Song Liu , Matt Mullins , Network Development , bpf , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 17, 2019 at 5:59 AM Arnd Bergmann wrote: > > When CONFIG_MODULES is disabled, this function is never called: > > kernel/trace/bpf_trace.c:581:13: error: 'do_bpf_send_signal' defined but not used [-Werror=unused-function] hmm. it should work just fine without modules. the bug is somewhere else.