Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 17 Jun 2019 17:29:23 +0200
Message-ID: <s5h4l4ofcx8.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Amadeusz =?UTF-8?B?U8WCYXdpxYRza2k=?= 
        <amadeuszx.slawinski@linux.intel.com>
Cc:     <alsa-devel@alsa-project.org>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        "Cezary Rojewski" <cezary.rojewski@intel.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
        "Jie Yang" <yang.jie@linux.intel.com>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/11] ALSA: hdac: Fix codec name after machine driver is unloaded and reloaded
In-Reply-To: <20190617113644.25621-3-amadeuszx.slawinski@linux.intel.com>
References: <20190617113644.25621-1-amadeuszx.slawinski@linux.intel.com>
        <20190617113644.25621-3-amadeuszx.slawinski@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 17 Jun 2019 13:36:35 +0200,
Amadeusz Sławiński wrote:
> 
> Currently on each driver reload internal counter is being increased. It
> causes failure to enumerate driver devices, as they have hardcoded:
> .codec_name = "ehdaudio0D2",
> As there is currently no devices with multiple hda codecs and there is
> currently no established way to reliably differentiate, between them,
> always assign bus->idx = 0;
> 
> This fixes a problem when we unload and reload machine driver idx gets
> incremented, so .codec_name would've needed to be set to "ehdaudio1D2"
> after first reload and so on.
> 
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>

Acked-by: Takashi Iwai <tiwai@suse.de>


Takashi