Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2859302ybi; Mon, 17 Jun 2019 11:34:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJDMl/xvUoVHskBS2zwsC7tFQn6c1iddyWT0yqURPXmyRL09kfxLN2IxrvulCLJNNwaPAE X-Received: by 2002:a17:902:9a91:: with SMTP id w17mr12818226plp.126.1560796492594; Mon, 17 Jun 2019 11:34:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560796492; cv=none; d=google.com; s=arc-20160816; b=fW31iyzMjfCsqcjfaVj+xgRKrIXYDnSHtu0J2++uew3F29M0R8Bs/Z4FeYGaj/1dGJ qhY8+uLEzmBDjt+y65kDLpwie65wsS2xkhGoyX70w645JIyGemKTSRufHD8/57Dpwkwb JglfqAtlrWN5vZ95EnoThjWD7JQwTOKi+ABREBmfnn6ij5WqiDsYtBJfLgzVCcJL3nK4 8B5324CiVSfZJEEqLZL5lS3SlIMSPOZ0QITszglsdR1Q4ExD6fXVixq4xYixiP80h0qq smPgP3OpAFtxd7v+FQKW8EXukNDUSLYgNeCZMFqWBdceQWtlAIyrrzedcuCIhKt/LYBU uccg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=cGDFCEOackaYxLLsw4eIh4Mb29sobDo79asIOukap1I=; b=z+HgVdzJbdrF+rRLoAduZ8lJlmSjEY92VTMQb0UXFKbPEYtqfBjvX9T672JL7Pi1kQ x1UaOnHRKRNozdrei1yDG8L1/yZMnbzPzRou5EDQPtC83GCp70i6LbCTg8EzbBFhKlku Ckh7FPOGaLCAtfUDtomjrjC764hQAuq24R9+DXdgq5DzOdEcH5eAYEOfyHW582pJpWTk ZLGB800emI7KLoWFzB3QlCjp7BF8SDUgOdOZIZ7+ADUAdi+3GYd7SxB8l3cRYVzotQxc vgtqeDRVHvy4GIxU61KREQX2CJGeIYlWnRaS1F6YTuRafhXbiaeVSNGq+F3fC2y8BRNU 6mCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d10si10337405pll.433.2019.06.17.11.34.36; Mon, 17 Jun 2019 11:34:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726248AbfFQSeV (ORCPT + 99 others); Mon, 17 Jun 2019 14:34:21 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:63904 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725764AbfFQSeV (ORCPT ); Mon, 17 Jun 2019 14:34:21 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5HIVqxq139552 for ; Mon, 17 Jun 2019 14:34:19 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2t6fmfsecb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 17 Jun 2019 14:34:19 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Jun 2019 19:34:18 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 17 Jun 2019 19:34:16 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5HIYFYW59572340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Jun 2019 18:34:15 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE26BAE057; Mon, 17 Jun 2019 18:34:14 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3586BAE04D; Mon, 17 Jun 2019 18:34:13 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.81.90]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 17 Jun 2019 18:34:13 +0000 (GMT) Subject: Re: [PATCH] firmware: improve LSM/IMA security behaviour From: Mimi Zohar To: Sven Van Asbroeck , Luis Chamberlain Cc: Stable , Mimi Zohar , Kees Cook , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Date: Mon, 17 Jun 2019 14:34:02 -0400 In-Reply-To: <20190617182354.10846-1-TheSven73@gmail.com> References: <20190617182354.10846-1-TheSven73@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19061718-0016-0000-0000-00000289E1A1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19061718-0017-0000-0000-000032E72CDD Message-Id: <1560796442.4072.170.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-17_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=914 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906170164 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-06-17 at 14:23 -0400, Sven Van Asbroeck wrote: > The firmware loader queries if LSM/IMA permits it to load firmware > via the sysfs fallback. Unfortunately, the code does the opposite: > it expressly permits sysfs fw loading if security_kernel_load_data( > LOADING_FIRMWARE) returns -EACCES. This happens because a > zero-on-success return value is cast to a bool that's true on success. > > Fix the return value handling so we get the correct behaviour. Reviewed-by: Mimi Zohar