Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2999167ybi; Mon, 17 Jun 2019 14:22:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvMMyf5kL1ZBDT/pCWEXOE6MDYzx9dpNjwzfDes893jUPz/3zj9GYMPpd8regGJm6p3p49 X-Received: by 2002:a17:902:30a3:: with SMTP id v32mr111274304plb.6.1560806528602; Mon, 17 Jun 2019 14:22:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560806528; cv=none; d=google.com; s=arc-20160816; b=mvTBTwcZd5zfMLvdGvLz+USLfO1zwz35iWCiPwib535esiOVs9Xjjfrx/Y/EgPv25x i8DhVEeLuml8vcLXTiNjKurB4NBby14BBc3/ZTZfA6shkc6+9CPAKFqqtqjqask7SRZn CTraOClaEhRIWTHQugMJMZ6TPnwJ3FgAMNIMgTg/zro97wxAE2zTeqnv5dYzP1Calq8D g/iS6EhLUYVXnzMiDRjkYiluONdBJ3R+2FeqaJKex+lc5zL3/zF0ka1drn0lJEaUAu60 zyp9UkjGWGkx3qShn/Y7nuIdC8FkHIyLjtViuWcYDfg6SvHsmxi9CP4C7q7Abcy4LwEi 2onw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=N3arLaeSYX1rO4YpcYkVyEdcWFsYs8iwFz5UIixAqrc=; b=tGQdq800iD1bSRK4G3FTzO/v3Gh9ITS21vGHkOL6sFJyklG67dJJrj8HaJi88ghLw8 oDFLCJm6XvtrcpRO1bFeEffdeDgVLcqfAlmJjveBGfQfo3qod9lXk2P/TJRS0EIISUXc vadACBxFlbRvHqH8KErOWtN/cHGvP1o9sECbqm9GaW3rN49AHrG8vyWMIjs5xDWp0VsP 4hlo77ouZzUHJ4nNnQF5sHKT5DkOKpm3qbEqisrhIthJJlxgwmbbrH+PDYgFCityiG5T S39W4+khqPLfbzp7bnbDdAPdTAWpZAsWIUfkbnUO9Ax+2W8AwR86pkuUrSSyJzBk9tGT LiTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f91si11708299plf.300.2019.06.17.14.21.53; Mon, 17 Jun 2019 14:22:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729258AbfFQVU7 (ORCPT + 99 others); Mon, 17 Jun 2019 17:20:59 -0400 Received: from www62.your-server.de ([213.133.104.62]:47160 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbfFQVU6 (ORCPT ); Mon, 17 Jun 2019 17:20:58 -0400 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hcz3a-0001JJ-NN; Mon, 17 Jun 2019 23:20:50 +0200 Received: from [178.199.41.31] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1hcz3a-0002B3-Hm; Mon, 17 Jun 2019 23:20:50 +0200 Subject: Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup To: Anton Protopopov , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , "David S. Miller" , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190615225348.2539-1-a.s.protopopov@gmail.com> From: Daniel Borkmann Message-ID: Date: Mon, 17 Jun 2019 23:20:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190615225348.2539-1-a.s.protopopov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25483/Mon Jun 17 09:56:00 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2019 12:53 AM, Anton Protopopov wrote: > The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED > when forwarding is disabled for the input device. However instead of checking > if forwarding is enabled on the input device, it checked the global > net->ipv6.devconf_all->forwarding flag. Change it to behave as expected. > > Signed-off-by: Anton Protopopov Applied, thanks!