Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Jun 2019 13:51:17 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To:     John Ogness <john.ogness@linutronix.de>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrea Parri <andrea.parri@amarulasolutions.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC PATCH v2 1/2] printk-rb: add a new printk ringbuffer
 implementation
Message-ID: <20190618045117.GA7419@jagdpanzerIV>
References: <20190607162349.18199-1-john.ogness@linutronix.de>
 <20190607162349.18199-2-john.ogness@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190607162349.18199-2-john.ogness@linutronix.de>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello John,

On (06/07/19 18:29), John Ogness wrote:
[..]
> +	struct prb_reserved_entry e;
> +	char *s;
> +
> +	s = prb_reserve(&e, &rb, 32);
> +	if (s) {
> +		sprintf(s, "Hello, world!");
> +		prb_commit(&e);
> +	}

A nit: snprintf().

sprintf() is tricky, it may write "slightly more than was
anticipated" bytes - all those string_nocheck(" disabled"),
error_string("pK-error"), etc.

[..]
> +Sample reader code::
> +
> +	DECLARE_PRINTKRB_ENTRY(entry, 128);
> +	DECLARE_PRINTKRB_ITER(iter, &test_rb, &entry);
> +	u64 last_seq = 0;
> +	int len;
> +	char *s;
> +
> +	prb_for_each_entry(&iter, len) {
> +		if (entry.seq - last_seq != 1) {
> +			printf("LOST %llu ENTRIES\n",
> +				entry.seq - (last_seq + 1));
> +		}
> +		last_seq = entry.seq;
> +
> +		s = (char *)&entry.buffer[0];
> +		if (len >= 128)
> +			s[128 - 1] = 0;
> +		printf("data: %s\n", s);
> +	}

How are we going to handle pr_cont() loops?

print_modules()
 preempt_disable();
 list_for_each_entry_rcu(mod, &modules, list) {
  pr_cont(" %s%s", mod->name, module_flags(mod, buf));
 }
 preempt_enable();

	-ss