Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naohiro Aota <Naohiro.Aota@wdc.com>
To:     Josef Bacik <josef@toxicpanda.com>
CC:     "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
        Qu Wenruo <wqu@suse.com>, Nikolay Borisov <nborisov@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        =?iso-8859-1?Q?Matias_Bj=F8rling?= <mb@lightnvm.io>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 02/19] btrfs: Get zone information of zoned block devices
Thread-Topic: [PATCH 02/19] btrfs: Get zone information of zoned block devices
Thread-Index: AQHVHTJ/1FX3VZfOTkaSGAxvcc7+NQ==
Date:   Tue, 18 Jun 2019 06:04:21 +0000
Message-ID: <SN6PR04MB52315752FF4D8E3CFF8801B38CEA0@SN6PR04MB5231.namprd04.prod.outlook.com>
References: <20190607131025.31996-1-naohiro.aota@wdc.com>
 <20190607131025.31996-3-naohiro.aota@wdc.com>
 <20190613135759.22siaadm7l4gz2ri@MacBook-Pro-91.local>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff130cc-6e51-48c9-775c-08d6f3b2ce8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2019 06:04:21.2979
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Naohiro.Aota1@wdc.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4941
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019/06/13 22:58, Josef Bacik wrote:=0A=
> On Fri, Jun 07, 2019 at 10:10:08PM +0900, Naohiro Aota wrote:=0A=
>> If a zoned block device is found, get its zone information (number of zo=
nes=0A=
>> and zone size) using the new helper function btrfs_get_dev_zonetypes(). =
 To=0A=
>> avoid costly run-time zone report commands to test the device zones type=
=0A=
>> during block allocation, attach the seqzones bitmap to the device struct=
ure=0A=
>> to indicate if a zone is sequential or accept random writes.=0A=
>>=0A=
>> This patch also introduces the helper function btrfs_dev_is_sequential()=
 to=0A=
>> test if the zone storing a block is a sequential write required zone.=0A=
>>=0A=
>> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
>> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>=0A=
>> ---=0A=
>>   fs/btrfs/volumes.c | 143 +++++++++++++++++++++++++++++++++++++++++++++=
=0A=
>>   fs/btrfs/volumes.h |  33 +++++++++++=0A=
>>   2 files changed, 176 insertions(+)=0A=
>>=0A=
> =0A=
> We have enough problems with giant files already, please just add a separ=
ate=0A=
> hmzoned.c or whatever and put all the zone specific code in there.  That'=
ll save=0A=
> me time when I go and break a bunch of stuff out.  Thanks,=0A=
> =0A=
> Josef=0A=
> =0A=
=0A=
Thank you for the reviews.=0A=
=0A=
I'll add hmzoned.c and put the things (with more helpers/abstraction) there=
 in the next version.=0A=
=0A=
Thanks.=0A=