Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3457185ybi; Tue, 18 Jun 2019 00:49:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8lvg/tlOsEgvCbFP1YWNLWcW6ZVyzsi5YhUYPEqXmgexJxs9F42Hehf7UXEWwWgl4XHiD X-Received: by 2002:a63:f342:: with SMTP id t2mr1355939pgj.83.1560844165780; Tue, 18 Jun 2019 00:49:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560844165; cv=none; d=google.com; s=arc-20160816; b=jCNqNo7E8vYrkUJVKuz5CS8Da+VDtDeNWF+k0xq7xs1j0aOarVdi+VOEySTIpXMdtf dDchp/33bUF5UOmlhbOFCutcRxzirQ2ZdSLwLEAwEqpYTVD0jS05cxQQCAKJNd8BWNjU klH2ZSG9dyCZpNBwv0c3FR6UP2wP44fkh6ZjsGYAzEV3NCUfS60YahX+ikLRlivCzG91 V22fJJscUfnwiU9fGjUy5AWSEm+av+ToZPx2gG6qVukxDjwBDBgGwJMKOmDJa5/FfcKa yG28rJWUusSEAGXmGkRB0ly4CD5XOZFqwlqn1MtUWYH/xOh3Gt2EHYuz6hMnulaE60YQ F7Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kT1vr4BvDfHo3ZKd3tJe/crE5cMuwBzj7KcxL1khJQc=; b=cKg90phYiHfuB9NhVn0tOLy9UhWB5KbBcGRi8NiYTcEhPdn8OJsQQStEnOxmvsotAJ UZQQmqmRUYbkZho/l71ABPgDpxE9v5r43hjLgewRmLaZiT8Qx7kLNlS5lajSoDa/MIdj V6RaZlHCiL3ai9A8owAG+ToPTiMvXzKVRtbLn+mBkw18jhgZNmRe8oJWNNXzmBO7Lhar wjRAZJevBfe1upIpqVRt008E+CCwpn6fFRK9WjWKd6YW2dH1psFBd9YpYd5DHe2Qtwrh seWH4LCamB/xxj0rp52nOTpEM+3gAk75qBF3aQqDaZasNw9STGtQxSbB0wFTTBkpmfaL YGmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vXHzl4rT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3si11561451pld.164.2019.06.18.00.49.10; Tue, 18 Jun 2019 00:49:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vXHzl4rT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726428AbfFRHtH (ORCPT + 99 others); Tue, 18 Jun 2019 03:49:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfFRHtG (ORCPT ); Tue, 18 Jun 2019 03:49:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87CB120663; Tue, 18 Jun 2019 07:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560844146; bh=5s30GomD44N92xGZszrfWfrIiZv9xCuvrxnPayt45R8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vXHzl4rTLK5B2MQBjMB7daMyhCH0b6oHm8NOrBCUaIAO4Rl2YuzkoOiDS8d7WntPK xUEKOhsQlG77RjUWW+WzokOgbFd0pejnYlX9zU2QBGguNYnTiWErh/UA29nQCsKG2C Guzaku0nCrA+RGI2mXHwXzUVZYQP+Ti3e07sXrY4= Date: Tue, 18 Jun 2019 09:49:03 +0200 From: Greg Kroah-Hartman To: Stefan Roese Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Yegor Yefremov , Mika Westerberg , Andy Shevchenko , Giulio Benetti Subject: Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers Message-ID: <20190618074903.GA5216@kroah.com> References: <20190611105603.4435-1-sr@denx.de> <20190611105603.4435-2-sr@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611105603.4435-2-sr@denx.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device > to not break existing ACPI based systems. Also only use the mctrl_gpio_ > functions when "gpios" is available. > > Signed-off-by: Yegor Yefremov > Signed-off-by: Greg Kroah-Hartman Please do not add a signed-off-by from people for an old patch that was reverted. It implies that I still agree with this change :( greg k-h