Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naohiro Aota <Naohiro.Aota@wdc.com>
To:     Josef Bacik <josef@toxicpanda.com>
CC:     "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
        Qu Wenruo <wqu@suse.com>, Nikolay Borisov <nborisov@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        =?iso-8859-1?Q?Matias_Bj=F8rling?= <mb@lightnvm.io>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 09/19] btrfs: limit super block locations in HMZONED mode
Thread-Topic: [PATCH 09/19] btrfs: limit super block locations in HMZONED mode
Thread-Index: AQHVHTKI41mlZbldhUiKC20uoMUKKg==
Date:   Tue, 18 Jun 2019 08:51:14 +0000
Message-ID: <SN6PR04MB5231E669DDB952D5EB9C12238CEA0@SN6PR04MB5231.namprd04.prod.outlook.com>
References: <20190607131025.31996-1-naohiro.aota@wdc.com>
 <20190607131025.31996-10-naohiro.aota@wdc.com>
 <20190613141232.nud7gqz622ewcyzp@MacBook-Pro-91.local>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c32c10c-71a4-440d-8063-08d6f3ca1eeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2019 08:51:14.5338
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Naohiro.Aota1@wdc.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4510
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019/06/13 23:13, Josef Bacik wrote:=0A=
> On Fri, Jun 07, 2019 at 10:10:15PM +0900, Naohiro Aota wrote:=0A=
>> When in HMZONED mode, make sure that device super blocks are located in=
=0A=
>> randomly writable zones of zoned block devices. That is, do not write su=
per=0A=
>> blocks in sequential write required zones of host-managed zoned block=0A=
>> devices as update would not be possible.=0A=
>>=0A=
>> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
>> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>=0A=
>> ---=0A=
>>   fs/btrfs/disk-io.c     | 11 +++++++++++=0A=
>>   fs/btrfs/disk-io.h     |  1 +=0A=
>>   fs/btrfs/extent-tree.c |  4 ++++=0A=
>>   fs/btrfs/scrub.c       |  2 ++=0A=
>>   4 files changed, 18 insertions(+)=0A=
>>=0A=
>> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c=0A=
>> index 7c1404c76768..ddbb02906042 100644=0A=
>> --- a/fs/btrfs/disk-io.c=0A=
>> +++ b/fs/btrfs/disk-io.c=0A=
>> @@ -3466,6 +3466,13 @@ struct buffer_head *btrfs_read_dev_super(struct b=
lock_device *bdev)=0A=
>>   	return latest;=0A=
>>   }=0A=
>>   =0A=
>> +int btrfs_check_super_location(struct btrfs_device *device, u64 pos)=0A=
>> +{=0A=
>> +	/* any address is good on a regular (zone_size =3D=3D 0) device */=0A=
>> +	/* non-SEQUENTIAL WRITE REQUIRED zones are capable on a zoned device *=
/=0A=
> =0A=
> This is not how you do multi-line comments in the kernel.  Thanks,=0A=
> =0A=
> Josef=0A=
> =0A=
=0A=
Thanks. I'll fix the style.=0A=
# I thought the checkpatch was catching this ...=0A=