Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3539471ybi; Tue, 18 Jun 2019 02:26:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQqRrgk6ylj5ngHoe4V9yMH0AvWu2l2MPfS3nCr1jCGobC/NXRO21DmxSinEhLUgdDM6uz X-Received: by 2002:a17:90a:9b8a:: with SMTP id g10mr3987757pjp.66.1560849975315; Tue, 18 Jun 2019 02:26:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560849975; cv=none; d=google.com; s=arc-20160816; b=B94pzxJ33eI2WxZHaa76cPnx72jEvzisNa/cizrrhWTAprTXdqMeGFn9eVK4oW5gae PCLFhlbu8Mz1Vwe7NI0+6wDvI7BLYTLetGn8qJg25GQaaQupdxXC028ewwc6wM55NXK+ tDJS8MCGK/Eo+5nHhLBYtygd1volUtLRFj3e/1FSKGVJjw8ArbyL9AlMLWSUvCmy07Mm FKhOM1WlSlpJPg1oOxYDU5aaWD8VLbTG7XSk4LG7xzs2Ka6h2bTXUMuz6UduTc+bbTZc ql1ONjWke761NOBXGj4fzwopzyXykMQxA09e1K7AyaikcESzFqTPOxySW2ncUGnbeNEE wBrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=fy71Uf996E2ckvMT5DeFO9vx2wQVOL602KlAxeyozyI=; b=YpIgYo95T3xaEZ77hj8jCYSWGOI3JKFbOuIjjoE63+Soc61N0iOCV8AXuwJRk+RHBr DQehovLgt47VMROVL6rJ0OfGn42lkMjykx0rel8CAsNCjTJh4yB/0Fk2sw61T52/UVT9 MuMqaj7a7bZiS3fpoFLSiQDr7WntewGn4ket02EA1LB8Mi4ESondjC5sFhlYyqpDlBcy nKqHCW5THtVDZ4nkfQD5sXoNPOpwyICschkhsF0Ihuhbh2px6p2LyprATpBBlEQxpAxK VhlPQC70qXQUhSxpezz3FC7Vgfojc08WQXykhANKBjOjHrKJkOxF8VU0QKZpYv59I1bk dteA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e96si12774004plb.123.2019.06.18.02.26.00; Tue, 18 Jun 2019 02:26:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729296AbfFRJZt (ORCPT + 99 others); Tue, 18 Jun 2019 05:25:49 -0400 Received: from foss.arm.com ([217.140.110.172]:59160 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728810AbfFRJZt (ORCPT ); Tue, 18 Jun 2019 05:25:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E4EC344; Tue, 18 Jun 2019 02:25:49 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E40263F246; Tue, 18 Jun 2019 02:25:47 -0700 (PDT) Date: Tue, 18 Jun 2019 10:25:40 +0100 From: Will Deacon To: Mike Rapoport Cc: Mark Rutland , Qian Cai , Andrew Morton , Catalin Marinas , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64/mm: don't initialize pgd_cache twice Message-ID: <20190618092540.GA30899@fuggles.cambridge.arm.com> References: <1560843149-13845-1-git-send-email-rppt@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560843149-13845-1-git-send-email-rppt@linux.ibm.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 10:32:29AM +0300, Mike Rapoport wrote: > When PGD_SIZE != PAGE_SIZE, arm64 uses kmem_cache for allocation of PGD > memory. That cache was initialized twice: first through > pgtable_cache_init() alias and then as an override for weak > pgd_cache_init(). > > Remove the alias from pgtable_cache_init() and keep the only pgd_cache > initialization in pgd_cache_init(). > > Fixes: caa841360134 ("x86/mm: Initialize PGD cache during mm initialization") > Signed-off-by: Mike Rapoport > --- > arch/arm64/include/asm/pgtable.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, Mike. Will