Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michal Kalderon <mkalderon@marvell.com>
To:     Arnd Bergmann <arnd@arndb.de>, Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "David S. Miller" <davem@davemloft.net>
CC:     Ariel Elior <aelior@marvell.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Denis Bolotin <dbolotin@marvell.com>,
        Tomer Tayar <tomer.tayar@cavium.com>,
        Sudarsana Reddy Kalluru <skalluru@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] qed: Fix -Wmaybe-uninitialized false positive
Thread-Topic: [PATCH] qed: Fix -Wmaybe-uninitialized false positive
Thread-Index: AQHVJQ1RjdAP7KlUu0KWNfQZMWSgEaahJdXw
Date:   Tue, 18 Jun 2019 09:27:28 +0000
Message-ID: <MN2PR18MB318218F121EBE1144A4AA36EA1EA0@MN2PR18MB3182.namprd18.prod.outlook.com>
References: <20190617130504.1906523-1-arnd@arndb.de>
In-Reply-To: <20190617130504.1906523-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 203523ef-8246-450f-00af-08d6f3cf2ee4
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2019 09:27:28.8478
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mkalderon@marvell.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2384
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-18_05:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Arnd Bergmann <arnd@arndb.de>
> Sent: Monday, June 17, 2019 4:05 PM
>=20
> A previous attempt to shut up the uninitialized variable use warning was
> apparently insufficient. When CONFIG_PROFILE_ANNOTATED_BRANCHES is
> set, gcc-8 still warns, because the unlikely() check in DP_NOTICE() cause=
s it to
> no longer track the state of all variables correctly:
>=20
> drivers/net/ethernet/qlogic/qed/qed_dev.c: In function
> 'qed_llh_set_ppfid_affinity':
> drivers/net/ethernet/qlogic/qed/qed_dev.c:798:47: error: 'abs_ppfid' may
> be used uninitialized in this function [-Werror=3Dmaybe-uninitialized]
>   addr =3D NIG_REG_PPF_TO_ENGINE_SEL + abs_ppfid * 0x4;
>                                      ~~~~~~~~~~^~~~~
>=20
> This is not a nice workaround, but always initializing the output from
> qed_llh_abs_ppfid() at least shuts up the false positive reliably.
>=20
> Fixes: 79284adeb99e ("qed: Add llh ppfid interface and 100g support for
> offload protocols")
> Fixes: 8e2ea3ea9625 ("qed: Fix static checker warning")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dev.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> index eec7cb65c7e6..a1ebc2b1ca0b 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> @@ -652,6 +652,7 @@ static int qed_llh_abs_ppfid(struct qed_dev *cdev, u8
> ppfid, u8 *p_abs_ppfid)
>  		DP_NOTICE(cdev,
>  			  "ppfid %d is not valid, available indices are
> 0..%hhd\n",
>  			  ppfid, p_llh_info->num_ppfid - 1);
> +		*p_abs_ppfid =3D 0;
>  		return -EINVAL;
>  	}
>=20
> --
> 2.20.0

Thanks,=A0

Acked-by: Michal Kalderon=A0<michal.kalderon@marvell.com>