Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190617122449.457744-1-arnd@arndb.de> <20190617122449.457744-2-arnd@arndb.de>
In-Reply-To: <20190617122449.457744-2-arnd@arndb.de>
From:   Olof Johansson <olof@lixom.net>
Date:   Tue, 18 Jun 2019 11:59:52 +0100
Message-ID: <CAOesGMhU9OHg_4xAiGy20KmXXLU62kONQxZ6DV5Tj+PKeBSJTg@mail.gmail.com>
Subject: Re: [PATCH 2/3] ARM: ixp4xx: mark ixp4xx_irq_setup as __init
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     ARM-SoC Maintainers <arm@kernel.org>,
        Linus Walleij <linusw@kernel.org>,
        Imre Kaloz <kaloz@openwrt.org>,
        Krzysztof Halasa <khalasa@piap.pl>,
        Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 17, 2019 at 1:25 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> Kbuild complains about ixp4xx_irq_setup not being __init
> itself in some configurations:
>
> WARNING: vmlinux.o(.text+0x85bae4): Section mismatch in reference from the function ixp4xx_irq_setup() to the function .init.text:set_handle_irq()
> The function ixp4xx_irq_setup() references
> the function __init set_handle_irq().
> This is often because ixp4xx_irq_setup lacks a __init
> annotation or the annotation of set_handle_irq is wrong.
>
> I suspect it normally gets inlined, so we get no such warning,
> but clang makes this obvious when the function is left out
> of line.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to arm/fixes. Thanks!


-Olof