Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751253AbVKWQfs (ORCPT ); Wed, 23 Nov 2005 11:35:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751241AbVKWQfs (ORCPT ); Wed, 23 Nov 2005 11:35:48 -0500 Received: from smtp.osdl.org ([65.172.181.4]:37810 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751253AbVKWQfr (ORCPT ); Wed, 23 Nov 2005 11:35:47 -0500 Date: Wed, 23 Nov 2005 08:35:27 -0800 (PST) From: Linus Torvalds To: Christoph Lameter cc: Andrew Morton , Rohit Seth , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]: Free pages from local pcp lists under tight memory conditions In-Reply-To: Message-ID: References: <20051122161000.A22430@unix-os.sc.intel.com> <20051122213612.4adef5d0.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 726 Lines: 25 On Tue, 22 Nov 2005, Christoph Lameter wrote: > On Tue, 22 Nov 2005, Andrew Morton wrote: > > > +extern int drain_local_pages(void); > > drain_cpu_pcps? Please no. If there is something I _hate_ it's bad naming. And "pcps" is a totally unintelligible name. Write it out. If a function is so trivial that you can't be bothered to write out what the name means, that function shouldn't exist at all. Conversely, if it's worth doing, it's worth writing out a name. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/