Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3803782ybi; Tue, 18 Jun 2019 06:49:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6DwAV6FGhV8NTzzh5bIhJxfPtc78qfXBFAFaXWe0GBP2NmSO6RdG4i8gHRquH+Vmfjf8V X-Received: by 2002:a63:296:: with SMTP id 144mr2849571pgc.141.1560865754219; Tue, 18 Jun 2019 06:49:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560865754; cv=none; d=google.com; s=arc-20160816; b=T0r+LEDimEbF/H457vNMo8nmiOcnhhflzylGbR0GmSRQgdRMi7GlIaukdIzrioEqqq oEWmnZcVL7CveCgWSioxazMKkhx3IHY+5Ksg6Bn4n7o33rcSzv2beIgz4gcMcrfAp7a3 HedH/GN071axf6RAKxt/pZGZkkWgc+6nPWvXdZk8m/xY/sFPjq8VrshQt8tBPMXtkrhd vKZ2e+IB6ob5gGYIY8NqiIUMhOMyiJA6kKCWxpqtGUoZXJhTqFXHLqTmiSfOxyQwKvrq vuc/dJkr9cbPqhyM6wkCCVZJAI79kY5+T1UCkp9mZHAxb/OCIf5FkO/5QSYCgwjaRiTc 9+pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iJmKAKxXNY/eDxKA8zSNselgrq1E+cvwinlMdmVZAj0=; b=xajb1oVLtmidbOa+aHjYm8hnQ4ztCvAWvvKfubSaiE/+bWjCYUYUbfzHTIFVUJ//NZ C1LSAlYs64Cnl0GXCryHYmAx4clbSASNOkV7HQsj+tkeh3nLCQmQU3jSHoiFWxXL1333 05IWHE9t0HVjmhS6+eyn5mWyD4bhF+JIXwlTgIkDg95PhUn4Fa5nXZZZ97KqfxUrvUdR yaTyADQBNczkfK9nx64QPYKxkPEygraDoT3VBWtGrB5nmWY+uNhUW0K4Vs6qOlgJOlxF 98xMozMmZBeifJ21dKKHzb36Vy+R3MNJP5BHSzNC7Qm+guteGNhebBkwP7K9cYT7Je12 Q/yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lixom-net.20150623.gappssmtp.com header.s=20150623 header.b=cacfGXld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d15si13488655plr.410.2019.06.18.06.48.58; Tue, 18 Jun 2019 06:49:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lixom-net.20150623.gappssmtp.com header.s=20150623 header.b=cacfGXld; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729516AbfFRNsY (ORCPT + 99 others); Tue, 18 Jun 2019 09:48:24 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:38931 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbfFRNsX (ORCPT ); Tue, 18 Jun 2019 09:48:23 -0400 Received: by mail-lf1-f67.google.com with SMTP id p24so9344595lfo.6 for ; Tue, 18 Jun 2019 06:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iJmKAKxXNY/eDxKA8zSNselgrq1E+cvwinlMdmVZAj0=; b=cacfGXldfdERA2D7/w1ynW2VQsTn1b7qk3uj0WDFrM0xboK5HuBE6GGyV+UDRf8kby isgNXremPdDITxn9XQ/vhZh9Qv43SxXMctARDoJqV+BLdixewV8O+zlRT3BSODYIZ6DE nd86ZP5rZkLGJ2m9+2yJZJ0SeZpVE61F9L1k1NTHBbeIrCnyg9Y4z9TxD3ZWoAzY0Q4o uwRB2fzVH7UoX7H8L8iiEJPEtnDJk8VfvwHd9Nz1FXFYGb76d4kEUOQ7hzuz3FAlOk2d y35hrhm6+qp063fseqIsJmWv1CEwQz0+XFX0WlSYV7eu2meM0FBw1PzTiHUUfNJRkHr+ zVfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iJmKAKxXNY/eDxKA8zSNselgrq1E+cvwinlMdmVZAj0=; b=p3eUHjpwSHeXNJLdGMloQFteriI9rBtaDDhXeD5U6YHldtEm07WeqXakICZtbtGDmi 5Kz9jgDhNSaZXe/v5UZRWFNi3TT0o5ys4RYh2HlEtwjkDQmbvEzx17A5aFc3ZsYlTEty dM15ITquRU7ifMfNnpzUM10NcTxYyejCCMn0NFhT6i6XpAaXqWDPf8IMDSV/qSUPBrVs STfMCOR/wReLysdn0rS7S2Lh2gWNBPCNiN3E2cxtdZ8MWDBemTppc2zlJJ78TZf159uw BW48vSQc4mlSQFUZr+IlemX8GVJlGNWAvTDYOZ11/I1EDH7XkrkNDMu/pGqgjetkojk8 IWPQ== X-Gm-Message-State: APjAAAWkDcQM146GJDHgRmXS2B13Qt8M7YX0MAlzojC/PnMuAqbeSCAW WAQRxaB7N6HKNTFFZGfnSuBKMA== X-Received: by 2002:ac2:495e:: with SMTP id o30mr59137674lfi.140.1560865701929; Tue, 18 Jun 2019 06:48:21 -0700 (PDT) Received: from localhost (h85-30-9-151.cust.a3fiber.se. [85.30.9.151]) by smtp.gmail.com with ESMTPSA id t21sm2211126lfl.17.2019.06.18.06.48.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 06:48:20 -0700 (PDT) Date: Tue, 18 Jun 2019 06:48:11 -0700 From: Olof Johansson To: Dan Carpenter Cc: arm@kernel.org, Krzysztof Halasa , Linus Walleij , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe Message-ID: <20190618134811.bfs5lxazaw66ubb7@localhost> References: <20190618115410.GE18776@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618115410.GE18776@kadam> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 02:54:10PM +0300, Dan Carpenter wrote: > The devm_ioremap_resource() function doesn't return NULL, it returns > error pointers. > > Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") > Signed-off-by: Dan Carpenter > Reviewed-by: Linus Walleij Applied, thanks! -Olof