Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbVKWRDk (ORCPT ); Wed, 23 Nov 2005 12:03:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932107AbVKWRDj (ORCPT ); Wed, 23 Nov 2005 12:03:39 -0500 Received: from graphe.net ([209.204.138.32]:49593 "EHLO graphe.net") by vger.kernel.org with ESMTP id S932093AbVKWRDi (ORCPT ); Wed, 23 Nov 2005 12:03:38 -0500 Date: Wed, 23 Nov 2005 09:03:34 -0800 (PST) From: Christoph Lameter X-X-Sender: christoph@graphe.net To: Linus Torvalds cc: Andrew Morton , Rohit Seth , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH]: Free pages from local pcp lists under tight memory conditions In-Reply-To: Message-ID: References: <20051122161000.A22430@unix-os.sc.intel.com> <20051122213612.4adef5d0.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 30 On Wed, 23 Nov 2005, Linus Torvalds wrote: > On Tue, 22 Nov 2005, Christoph Lameter wrote: > > On Tue, 22 Nov 2005, Andrew Morton wrote: > > > +extern int drain_local_pages(void); > > drain_cpu_pcps? > > Please no. > > If there is something I _hate_ it's bad naming. And "pcps" is a totally > unintelligible name. > > Write it out. If a function is so trivial that you can't be bothered to > write out what the name means, that function shouldn't exist at all. > Conversely, if it's worth doing, it's worth writing out a name. drain_one_cpus_pages_from_per_cpu_pagesets() drain_one_cpus_remote_pages_from_per_cpu_pagesets() drain_all_per_cpu_pagesets() ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/