Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3959065ybi; Tue, 18 Jun 2019 09:14:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNgsKDyffTTrRwAkvSASdWQqpGvB8J76DdDawKclDeNam/hkqEOy9UgaQhbna0LhWmM3go X-Received: by 2002:a17:90a:a00d:: with SMTP id q13mr5929139pjp.80.1560874467497; Tue, 18 Jun 2019 09:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560874467; cv=none; d=google.com; s=arc-20160816; b=FIN4I7dWim5Vc8/89CZHtkip2zdhOmPbVfl56WbkVt9Mhk+8ebPQB7ciayXOLd79Y8 WIc6Ewc7dgZ4QkQvGz9PIHMcRNdRsEJuS0x7KNSEB4zPaRo8F3D5AvLJqCgMK2AMg+fa nvtCQqUQz8PeFcElhxzvqZuHiO5mm7YtvIjiryjX5SIypmupvTZyWDDf3v5lfM0XsFIX uB79YjqV+fCz0iy/mBKn8HRbPv/Kxqos3zzVuvqkonuJnmttwY7NHzkYFMhe3M+BtUoG ZCDWcHdP6dryqa3YFsuD4UZbFmISZCmkNuD2kdAiO+g4SG9Kl+FPcugFdh1X1HKLvGOV Ciiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yfCmDn4z0T2c39cSOjUskTcH8g/QZTaxgdNZE71djt0=; b=NahS0HqeKz+i9FdykOS6CDOj9GTOJjZrB6EBDwJDLAX8SOtTjfyOu+V39z/4B/1W3n CnegcMVhadgEP1woohMOPvkAkQRuRTfJX8k5JFeKgXHO8dN4JPg57YHzEQWqvANzxvDI /2uh066/el7Rm5WO/FmLNvHojPuckhKOspwr+XBzi6gmvBBtL2u3Ztzqkb5ymD9QRuLn eSQea+I4uDR7AZbs+7XvnknHmZG4BGmtRVkD/k+xH2P+REidZ2h7Rj34y8pzNI1SVxX9 NJIIexLiCdGlPaYayQd1WfUqubDK0volpr7m3S6h1HvXHg9z39bqmGsU0DA3O7PNrWgb 178Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Io7Qr15/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si6792248pfk.246.2019.06.18.09.14.11; Tue, 18 Jun 2019 09:14:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Io7Qr15/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729605AbfFRQNn (ORCPT + 99 others); Tue, 18 Jun 2019 12:13:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:51042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729249AbfFRQNn (ORCPT ); Tue, 18 Jun 2019 12:13:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF82B20B1F; Tue, 18 Jun 2019 16:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560874422; bh=bVVkiFHLJaXqthJlNED1JjG6SMoMKVmDToBpACNCwTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Io7Qr15/LSttBNs/+tDG05cnvzqIJHScRK0PKh95Q99XXk382mpxo6LJrg8l60WfV dQjYT/H5KwKYQ4I8sNpBxBrMN4OBGMBy49X1IVQaeu0Y408AZxdMZh3QR3I5KVHFde 8MMYh/hPHE6ckWA7dt0Ezplj2twor1JAXb9YHWfo= Date: Tue, 18 Jun 2019 18:13:40 +0200 From: Greg KH To: Muchun Song Cc: "Rafael J. Wysocki" , Benjamin Herrenschmidt , Prateek Sood , Mukesh Ojha , gkohli@codeaurora.org, linux-kernel , linux-arm-msm , zhaowuyun@wingtech.com Subject: Re: [PATCH v4] driver core: Fix use-after-free and double free on glue directory Message-ID: <20190618161340.GA13983@kroah.com> References: <20190516142342.28019-1-smuchun@gmail.com> <20190524190443.GB29565@kroah.com> <20190618152859.GB1912@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 19, 2019 at 12:09:40AM +0800, Muchun Song wrote: > Greg KH 于2019年6月18日周二 下午11:29写道: > > > > On Tue, Jun 18, 2019 at 09:40:13PM +0800, Muchun Song wrote: > > > Ping guys ? I think this is worth fixing. > > > > That's great (no context here), but I need people to actually agree on > > what the correct fix should be. I had two different patches that were > > saying they fixed the same issue, and that feels really wrong. > > Another patch: > Subject: [PATCH v3] drivers: core: Remove glue dirs early only > when refcount is 1 > > My first v1 patch: > Subject: [PATCH] driver core: Fix use-after-free and double free > on glue directory > > The above two patches are almost the same that fix is based on the refcount. > But why we change the solution from v1 to v4? Some discussion can > refer to the mail: > > Subject: [PATCH] driver core: Fix use-after-free and double free > on glue directory Again, I am totally confused and do not see a patch in an email that I can apply... Someone needs to get people to agree here... thanks, greg k-h