Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting
 signed 32-bit value by 31 bits problem
To:     Greg KH <gregkh@linuxfoundation.org>,
        Puranjay Mohan <puranjay12@gmail.com>
Cc:     hch@infradead.org, linux-kernel-mentees@lists.linuxfoundation.org,
        linux-kernel@vger.kernel.org,
        "skh >> Shuah Khan" <skhan@linuxfoundation.org>
References: <20190618114947.10563-1-puranjay12@gmail.com>
 <20190618160847.GC27611@kroah.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <777ee79c-9371-956a-07df-be866796047b@linuxfoundation.org>
Date:   Tue, 18 Jun 2019 10:15:11 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190618160847.GC27611@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 6/18/19 10:08 AM, Greg KH wrote:
> On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote:
>> Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed
>> 32-bit value by 31 bits problem. This isn't a problem for kernel builds
>> with gcc.
>>
>> This could be problem since this header is part of public API which
>> could be included for builds using compilers that don't handle this
>> condition safely resulting in undefined behavior.
>>
>> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> You should resend this and cc: Nicolas Pitre <nico@fluxnic.net> as he is
> the cramfs maintainer.
> 

Puranjay! You can add all the Reviewed-by tags when you resend the patch
with Nicolas Pitre <nico@fluxnic.net> on the thread.


Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah