Message-ID: <4384A84B.5080709@tmr.com>
Date: Wed, 23 Nov 2005 12:35:07 -0500
From: Bill Davidsen <davidsen@tmr.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.11) Gecko/20050729
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
CC: moreau francis <francis_moreau2000@yahoo.fr>, linux-kernel@vger.kernel.org
Subject: Re: Use enum to declare errno values
References: <20051123132443.32793.qmail@web25813.mail.ukl.yahoo.com>	 <200511231631.12365.vda@ilport.com.ua> <1132758910.7268.32.camel@localhost.localdomain>
In-Reply-To: <1132758910.7268.32.camel@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1145
Lines: 31

Alan Cox wrote:
> On Mer, 2005-11-23 at 16:31 +0200, Denis Vlasenko wrote:
> 
>>Enums are really nice substitute for integer constants instead of #defines.
>>Enums obey scope rules, #defines do not.
>>
>>However enums are not widely used because of
>>1. tradition and style
>>2. awkward syntax required:   enum { ABC = 123 };
> 
> 
> The SATA layer uses enum for constants and while it was a bit of change
> in style when I met it, it does seem to work just as well
> 

Well, perhaps better, since there is some type checking, and where 
auto-increment can be used finger checks don't generate duplicate values 
or undefined holes in the value set.

Like the struct definitions vs. old K&R definitions, there is a mental 
style adjustment to be made.
-- 
    -bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
  last possible moment - but no longer"  -me

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/