Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbVKWSSd (ORCPT ); Wed, 23 Nov 2005 13:18:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932131AbVKWSSc (ORCPT ); Wed, 23 Nov 2005 13:18:32 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:42967 "HELO iolanthe.rowland.org") by vger.kernel.org with SMTP id S932132AbVKWSSb (ORCPT ); Wed, 23 Nov 2005 13:18:31 -0500 Date: Wed, 23 Nov 2005 13:18:30 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Bob Copeland cc: linux-kernel@vger.kernel.org, Subject: Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma In-Reply-To: <20051123113342.GA5815@hash.localnet> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 27 On Wed, 23 Nov 2005, Bob Copeland wrote: > --- a/drivers/usb/storage/unusual_devs.h > +++ b/drivers/usb/storage/unusual_devs.h > @@ -145,6 +145,13 @@ UNUSUAL_DEV( 0x0451, 0x5416, 0x0100, 0x > US_SC_DEVICE, US_PR_BULK, NULL, > US_FL_NEED_OVERRIDE ), > > +#ifdef CONFIG_USB_STORAGE_KARMA > +UNUSUAL_DEV( 0x045a, 0x5210, 0x0101, 0x0101, > + "Rio", > + "Rio Karma", > + US_SC_SCSI, US_PR_BULK, rio_karma_init, US_FL_FIX_INQUIRY), Are you sure you need US_SC_SCSI and US_PR_BULK? Wouldn't US_SC_DEVICE and US_PR_DEVICE be sufficient? And do you really need US_FL_FIX_INQUIRY? Hardly any devices do (maybe none). Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/