Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4151325ybi;
        Tue, 18 Jun 2019 12:45:11 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxqSaIru3fPID3qhbLznUTUg2/Mv0Cy1yjEi4OZJxd74jNBLzo8CKABltf6OxE38R73Z86L
X-Received: by 2002:a63:5152:: with SMTP id r18mr4026893pgl.94.1560887111311;
        Tue, 18 Jun 2019 12:45:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1560887111; cv=none;
        d=google.com; s=arc-20160816;
        b=aqMXjzm4x7k/ZAKtNax70WpfLt9nJIDyTVA4N3w2xtqlSHmA84ifvff+XbNR8NPzb7
         PnU/5tIqqr9cBNlfRUl+oGgOE6eK9TYZ7R4YC4QhgP3AALvtJYGTU711H2nsXgr5LfvL
         i+sWZpcq7YQOZ9nNuFRpV4ha63XbxwWszk/KajqOI1may4e1yIzbSnh0L5JTAktqZtjE
         LDTfIgMI8RWgz1M8lDoEr2oGl447FBxlpdM9VtxUdGT3QVILkbTB9cB0KL25Gs1CrBWx
         icRXVldhkd4sF1JzLXsxBfHi4Hd+ztLM//8Ru9I4yHq7S/vxjcHsOTboL1/ZkswGYh5Y
         Od5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=PwZarqBwDAlCSx+BZ96mh7Tp8BKOluB88TjkXU/xKMw=;
        b=EalEfsWyHrHqVuZEXdIiL7qAG5aIwLNg0jDhz3ORAf9RGunQ3pvqMMwpVyi5pma87b
         8TPGSyLUF4iJ6OPxCRRFwvcGLfzPE/RbvaiASEB9N8uVRhtqLOnLA/qE3Y6JVIoU+yVh
         oDGsWIJgiMRVuEyuR4ju6+LkiwYCPeYvg8PnHRGZztvSFEbAHx+JRua02EFjRUvt31+5
         n5DDf8KHMzmatzVoMNLOByZMJVDGXteZDlVzx8aKZYC9dFNqMMnDOKI0rvq2LU/DcQvr
         Dpwuqp7MQGi4LRhKQ0XhrnB9a5rNtOkcNKNM2UQ0aRk8NkH37GbFvW25gEZXs1x0o6v9
         ZxCA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=R4uJclZH;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id j17si14039688pfr.13.2019.06.18.12.44.55;
        Tue, 18 Jun 2019 12:45:11 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=R4uJclZH;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730470AbfFRToR (ORCPT <rfc822;carmate383@gmail.com>
        + 99 others); Tue, 18 Jun 2019 15:44:17 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:14507 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725909AbfFRToR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jun 2019 15:44:17 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d093f100000>; Tue, 18 Jun 2019 12:44:16 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Tue, 18 Jun 2019 12:44:16 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Tue, 18 Jun 2019 12:44:16 -0700
Received: from [10.26.11.81] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Jun
 2019 19:44:13 +0000
Subject: Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove
 phylib logic
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Jose Abreu <Jose.Abreu@synopsys.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Joao Pinto <Joao.Pinto@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Russell King <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        linux-tegra <linux-tegra@vger.kernel.org>
References: <cover.1560266175.git.joabreu@synopsys.com>
 <6226d6a0de5929ed07d64b20472c52a86e71383d.1560266175.git.joabreu@synopsys.com>
 <d9ffce3d-4827-fa4a-89e8-0492c4bc1848@nvidia.com>
 <78EB27739596EE489E55E81C33FEC33A0B9C8D6E@DE02WEMBXB.internal.synopsys.com>
 <26cfaeff-a310-3b79-5b57-fd9c93bd8929@nvidia.com>
 <78EB27739596EE489E55E81C33FEC33A0B9C8DD9@DE02WEMBXB.internal.synopsys.com>
 <b66c7578-172f-4443-f4c3-411525e28738@nvidia.com>
 <d96f8bea-f7ef-82ae-01ba-9c97aec0ee38@nvidia.com>
Message-ID: <6f36b6b6-8209-ed98-e7e1-3dac0a92f6cd@nvidia.com>
Date:   Tue, 18 Jun 2019 20:44:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <d96f8bea-f7ef-82ae-01ba-9c97aec0ee38@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1560887056; bh=PwZarqBwDAlCSx+BZ96mh7Tp8BKOluB88TjkXU/xKMw=;
        h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=R4uJclZHP4uqM8KUkkbfj3B9imly/wEhiSJ+rvRgRqF3AJa6y9N1BU6AXqkxxAAN1
         mNyagoJzU6qaXcWda8VeAbmZLFnX75S6fAuQQHcvCk3gd2EShrvgg1Z+bjMMc4B8rG
         FJu/aAOR/Exkzc6LDxCm9bJ8mUYHGeMtsrFgMASjIzGq+V35FV3nybMf5El3fm2l2c
         a9IXt/mfbR5HkwAzEORHNYj/z0kXPVAYYDufwAP4cL4C61y+gIAHwH/PXO/UTUq1YL
         0SH0j61GFIRBnjbVDvzrPYmzQexp/GLub91IIoZcWbLe8IdIUEPvNW+KAN/m6Wuzle
         rvnwW7P2e7h7Q==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/06/2019 16:20, Jon Hunter wrote:
> 
> On 18/06/2019 11:18, Jon Hunter wrote:
>>
>> On 18/06/2019 10:46, Jose Abreu wrote:
>>> From: Jon Hunter <jonathanh@nvidia.com>
>>>
>>>> I am not certain but I don't believe so. We are using a static IP address
>>>> and mounting the root file-system via NFS when we see this ...
>>>
>>> Can you please add a call to napi_synchronize() before every 
>>> napi_disable() calls, like this:
>>>
>>> if (queue < rx_queues_cnt) {
>>> 	napi_synchronize(&ch->rx_napi);
>>> 	napi_disable(&ch->rx_napi);
>>> }
>>>
>>> if (queue < tx_queues_cnt) {
>>> 	napi_synchronize(&ch->tx_napi);
>>> 	napi_disable(&ch->tx_napi);
>>> }
>>>
>>> [ I can send you a patch if you prefer ]
>>
>> Yes I can try this and for completeness you mean ...
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 4ca46289a742..d4a12cb64d8e 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -146,10 +146,15 @@ static void stmmac_disable_all_queues(struct stmmac_priv *priv)
>>         for (queue = 0; queue < maxq; queue++) {
>>                 struct stmmac_channel *ch = &priv->channel[queue];
>>  
>> -               if (queue < rx_queues_cnt)
>> +               if (queue < rx_queues_cnt) {
>> +                       napi_synchronize(&ch->rx_napi);
>>                         napi_disable(&ch->rx_napi);
>> -               if (queue < tx_queues_cnt)
>> +               }
>> +
>> +               if (queue < tx_queues_cnt) {
>> +                       napi_synchronize(&ch->tx_napi);
>>                         napi_disable(&ch->tx_napi);
>> +               }
>>         }
>>  }
> 
> So good news and bad news ...
> 
> The good news is that the above change does fix the initial crash
> I am seeing. However, even with this change applied on top of
> -next, it is still dying somewhere else and so there appears to
> be a second issue. 

Further testing has shown that actually this does NOT resolve the issue
and I am still seeing the crash. Sorry for the false-positive.

Jon

-- 
nvpublic