Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4185970ybi; Tue, 18 Jun 2019 13:25:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqxBBhSgsHYeQ/yHu18LMORIF33GHdX5sJ29H16qaoKBVV3FuCgSRgICkDUl1lbW2+W0BqJp X-Received: by 2002:a63:e53:: with SMTP id 19mr4296189pgo.137.1560889529656; Tue, 18 Jun 2019 13:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560889529; cv=none; d=google.com; s=arc-20160816; b=BMoTWV78zSCEp1J1Y5bN4s87xzc98EkIntqePc7GbtVBqFQwJBYmluzGTc35kk1xxl OYxa9Sd4Fxdv+KKixHSYo29JcOY8p8tCIkIxLgXcALwq5ynRHnM31nhzt8k7Gu10343j jvo55Hm8Elj93OmZMWAw6Yqxua9uZ60p7ieso7tHXnjLcqnuL9WBvL70Lvpu6s2Jk4tF vCIlP6BjyV5nsZb1mhC8w7gPpxOpWrUgGWqdBQTrk4kwpCy4wUi7auH/yAQ51oyxjm83 vITjUG3W8WgDQuz6p+W/wiRqM9wQEiQxEKGUJNHFvcWDTVXKFcQSlmJ7fBOFqJtpjGUc y8BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=P1W/63zslUjqHIXEHvrk2kgZqRsyN76FfAUM1t8isQI=; b=QoW2CwoY2ESVqsC3b7u4Opo6DDMS1tFyJ1zZsexRdvXlsQwwlFVkzjTT/+wuF7NJOF lYDP7ti9e0/UGYaMgU0Bnsk3XxBGv5FiXv6TWunIohDDJm412peSanddjfCT/kwsJVFj vpLbG3Rw8HiNnauzO+yKcXXfl7PjWIWTgpbgVftLxdOIiDx+FHVrrVr0Lp3Hk+rApitF eTUfhiSYYqlmiHQoePemuQINw55IbLx5EioChNbOfZxuDeB4GWwoHZqfp+Aq4cR/wZGH wZ5BeHWa/WFCES2cvMg0U232/eIPaFkzHUStd4d6UqqctWVrcqWU3lSdHd5rD+Bwh0yR ZwSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 13si14025810pfo.163.2019.06.18.13.25.14; Tue, 18 Jun 2019 13:25:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730635AbfFRUYm convert rfc822-to-8bit (ORCPT + 99 others); Tue, 18 Jun 2019 16:24:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:12871 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730510AbfFRUYl (ORCPT ); Tue, 18 Jun 2019 16:24:41 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2019 13:24:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,390,1557212400"; d="scan'208";a="357972736" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga005.fm.intel.com with ESMTP; 18 Jun 2019 13:24:39 -0700 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.92]) by ORSMSX103.amr.corp.intel.com ([169.254.5.135]) with mapi id 14.03.0439.000; Tue, 18 Jun 2019 13:24:37 -0700 From: "Moore, Robert" To: Nikolaus Voss CC: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , "Schmauss, Erik" , Jacek Anaszewski , Pavel Machek , Dan Murphy , Thierry Reding , ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , "linux-leds@vger.kernel.org" , Linux PWM List , Linux Kernel Mailing List Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads Thread-Topic: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads Thread-Index: AQHVIPn/qqDB5Bv4z0aSsleXlAnDw6abVhaAgAADpwD///G0sIAEkokAgACES6CAAT+dAIAANdnAgAALWnCAAAJ3oA== Date: Tue, 18 Jun 2019 20:24:37 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B95FB097@ORSMSX110.amr.corp.intel.com> References: <94F2FBAB4432B54E8AACC7DFDE6C92E3B95EFB26@ORSMSX110.amr.corp.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E3B95F9EC6@ORSMSX110.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWYzNDM4MzQtOGVmNS00ZTRiLWJkZTktZDExNTM1YTg5ZDk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialA3Y1d2Z3ZkMnZ2VUpzaXc3aDBTaWxGMFFmdEE4QUdvRCtYSHUrWWozN0g3cnRLckZMc1hwbEdXZkdmditHZiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If it is in fact the AcpiLoadTable interface that is incorrect, that of course is different. I'll check that out next. > -----Original Message----- > From: Moore, Robert > Sent: Tuesday, June 18, 2019 1:23 PM > To: 'Nikolaus Voss' > Cc: 'Rafael J. Wysocki' ; 'Rafael J. Wysocki' > ; 'Len Brown' ; Schmauss, Erik > ; 'Jacek Anaszewski' > ; 'Pavel Machek' ; 'Dan > Murphy' ; 'Thierry Reding' ; > 'ACPI Devel Maling List' ; 'open list:ACPI > COMPONENT ARCHITECTURE (ACPICA)' ; 'linux- > leds@vger.kernel.org' ; 'Linux PWM List' > ; 'Linux Kernel Mailing List' kernel@vger.kernel.org> > Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table > loads > > It looks to me that the package objects are being initialized properly > already, unless I'm missing something. Please check the examples below > and in the attached files. > > Attached is a small test case that dynamically loads an SSDT which > contains a package object which in turn contains references to other > objects. > > > Main DSDT: > Method (LD1) > { > Load (BUF1, HNDL) // SSDT is in BUF1 > Store (HNDL, Debug) > Return > } > > Loaded table: > External (DEV1, DeviceObj) > Name (PKG1, Package() { > 1,2, DEV2, DEV1, 4}) > Device (DEV2) {} > > > AcpiExec Output: > - ev ld1 > Evaluating \LD1 > ACPI: Dynamic OEM Table Load: > ACPI: SSDT 0x00000000006DEEB8 000051 (v02 Intel Load 00000001 INTL > 20190509) > ACPI Exec: Table Event INSTALL, [SSDT] 006DEEB8 > Table [SSDT: Load ] (id 06) - 5 Objects with 1 Devices, 0 > Regions, 1 Methods > ACPI Exec: Table Event LOAD, [SSDT] 006DEEB8 ACPI Debug: Reference > [DdbHandle] Table Index 0x3 > 0x7 Outstanding allocations after evaluation of \LD1 Evaluation of \LD1 > returned object 006D2FE8, external buffer length 18 > [Integer] = 0000000000000000 > > - ev pkg1 > Evaluating \PKG1 > Evaluation of \PKG1 returned object 006D2FE8, external buffer length 90 > [Package] Contains 5 Elements: > [Integer] = 0000000000000001 > [Integer] = 0000000000000002 > [Object Reference] = 006DDF88 Name DEV2 Device > [Object Reference] = 006DD608 Name DEV1 Device > [Integer] = 0000000000000004