Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4282246ybi; Tue, 18 Jun 2019 15:19:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqz2yNolLqMtC803cx/efGfRFsFZ5wQoZha8fvWnC63ctVxQOb70hVxJCemxGApt1HwRj3RT X-Received: by 2002:aa7:8e54:: with SMTP id d20mr32866493pfr.16.1560896353831; Tue, 18 Jun 2019 15:19:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560896353; cv=none; d=google.com; s=arc-20160816; b=q9SppL4W0uUWI1yCg6ZHQ/s95ztSPu+wC50ykC2SsVI+pGmA8knzorugz74eF8n6PS HKiZ+KLfncQJ7YAnnYw4AwMQFAZWGUhutCoxyv2cO+ffquZzAPzWcvHJ4/N8ApOnrfhX orrjGVkRF/KmP3S+YDBLexsMQ431HKjN9IfhjTcpyaZeG7AeiI77/OwwEZ4nVnMJUMfs 04AW85CV8oqoeOLzkaIzno2pUisfnMtRipIl0ictIppltCDY6/PbLKaPm+eVqEMrNL6W j9nxCc6j0SnQCFSGnVAn68v4LgcrLrb9rIsWkXNEcAPeMl5ECve0Jc0YYtQTDsW7JbXw CZPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=r9jSf+GvleJiERCeevkGpawjeDa9IKrkZ13o0s0G690=; b=A8Ari4HBM/tQ8AdaM+jcPwr1E8jo1dq798XsFcvn8wVCBGdvKi/ToyBtFZU17RCgRV q6iIHaltl8BrjDT6Vvt53o/S1oaLbL33Z7KPuPSeVOrUghXo26RQq9MXmrnY8VG1enW8 9vl9MXo9J5ow6hOshR9hjq4xSf4/ge3ujaXmHMZ7bWRo+zEGFFRaREenyMs+QYB3OyZr Af6NUTq+1WR4h2tFM9J2DrDFH7V7Wf1KoeiB2PY6yc0KeLQASPI4ddUwZMsb7vksPojc zCU3zcARLzGr/zQ8Rn8MMnA98KVXiSvJiq8faSLtRUXOMVfT8+4a6bAHSjCfEc+TUkAd jYjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m25si1190551pgv.481.2019.06.18.15.18.58; Tue, 18 Jun 2019 15:19:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730788AbfFRWSt (ORCPT + 99 others); Tue, 18 Jun 2019 18:18:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48950 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729982AbfFRWSs (ORCPT ); Tue, 18 Jun 2019 18:18:48 -0400 Received: from localhost ([127.0.0.1] helo=vostro.local) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1hdMQk-00067m-3p; Wed, 19 Jun 2019 00:18:18 +0200 From: John Ogness To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , Sergey Senozhatsky Subject: Re: [RFC PATCH v2 1/2] printk-rb: add a new printk ringbuffer implementation References: <20190607162349.18199-1-john.ogness@linutronix.de> <20190607162349.18199-2-john.ogness@linutronix.de> <20190618111215.GO3436@hirez.programming.kicks-ass.net> Date: Wed, 19 Jun 2019 00:18:16 +0200 In-Reply-To: <20190618111215.GO3436@hirez.programming.kicks-ass.net> (Peter Zijlstra's message of "Tue, 18 Jun 2019 13:12:15 +0200") Message-ID: <87ef3qbkrb.fsf@linutronix.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-06-18, Peter Zijlstra wrote: >> +/** >> + * struct prb_descr - A descriptor representing an entry in the ringbuffer. >> + * @seq: The sequence number of the entry. >> + * @id: The descriptor id. >> + * The location of the descriptor within the descriptor array can be >> + * determined from this value. >> + * @data: The logical position of the data for this entry. >> + * The location of the beginning of the data within the data array >> + * can be determined from this value. >> + * @data_next: The logical position of the data next to this entry. >> + * This is used to determine the length of the data as well as >> + * identify where the next data begins. >> + * @next: The id of the next (newer) descriptor in the linked list. >> + * A value of EOL means it is the last descriptor in the list. >> + * > > For the entire patch; can you please vertically align those > descriptions? This is unreadable. Also, add some whitespace, to aid with > reading, something like do: > > * struct prb_descr - A descriptor representing an entry in the ringbuffer. > * > * @seq: The sequence number of the entry. > * > * @id: The descriptor id. > * The location of the descriptor within the descriptor > * array can be determined from this value. > * > * @data: The logical position of the data for this entry. The > * location of the beginning of the data within the data > * array can be determined from this value. > * > * @data_next: The logical position of the data next to this entry. > * This is used to determine the length of the data as well as > * identify where the next data begins. > * > * @next: The id of the next (newer) descriptor in the linked list. > * A value of EOL means it is the last descriptor in the > * list. OK. Thanks for taking the time to format an example. John Ogness