Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp36978ybi; Tue, 18 Jun 2019 16:53:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8FEfXOIeHcnCNNsb+a/ZYBiTIz2eWaSapHAJbARAmgc68uNeeo1OMuBf+HX2sb7WztdjK X-Received: by 2002:a63:b90d:: with SMTP id z13mr4945185pge.16.1560901984094; Tue, 18 Jun 2019 16:53:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560901984; cv=none; d=google.com; s=arc-20160816; b=sl/NJJKijqBLuOZAuAIBW1D+BFG6eDKb5e2w4gDYcuBWatONf+/0aGi1d5ETxPD9+B fUT1eE3b3LGBwN4xUPMcE2hu3k3F2yYvMX09D5fWOMs0jqDFrNSp6llCgZ+h6+aJg8Bh wlISHkJEx0RMEKXBbuqfaVD9Wthkx1arH0iMF7ciqg2Tfb98n8Jen8O2/4LoJGgjMTBl qqpX2+rPM+wefmXaNEMxL8rZi1pobCBk44l9p8kxo9IOj7TaLQwF5wb3YKXZv/OeYNd/ YdxiWI1HYPrCNTphK371hUdnmqtVVtJNjTiDyt6UyxbUj8okCeUixAdcE8DNgihT+6rK Icgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=oxhoe6qvi5++Tcm34QYjpxvVrTyaf87PFGxTM5J5klQ=; b=QssqY+gBtpQlhasUev2SXWH3Z/swULPAdrV9J5Q9jBzumFCuGBoFxU4QUBpi6pGSP2 32xowhfY3sG7OYvy7b+/IcO2ZEJly7sVlcd/qVfVcccOwMgTaktmgM19ySpM+cPWK2Cm e+2JQhuY0v8QkuR0I1T3JOyhaw4XgvicwgtxdW6WTHjcBI0G8XtBqGyP1s/FBB5qkrJw Chh2+OunT8fnGP880dSMeQpLTdSg/8oyHigS+FLdtSEOhH8pyCl35PjeSHV20py1bYQN v4JSCKRCmLuC+DvLBMForYE3GIxIDxGIYq1APruFSfWPhGRnODczajlZyyZ7ehcgFlfL Vo5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Hw8Wh065; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m22si1384781pgv.303.2019.06.18.16.52.47; Tue, 18 Jun 2019 16:53:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Hw8Wh065; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726446AbfFRXwg (ORCPT + 99 others); Tue, 18 Jun 2019 19:52:36 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:41689 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfFRXwf (ORCPT ); Tue, 18 Jun 2019 19:52:35 -0400 Received: by mail-qt1-f196.google.com with SMTP id d17so12767447qtj.8 for ; Tue, 18 Jun 2019 16:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oxhoe6qvi5++Tcm34QYjpxvVrTyaf87PFGxTM5J5klQ=; b=Hw8Wh065g4/hqpkCuE2UUCCyaWWEgEqIivqSK4AXMEYZFcGFB/YyRBBxDQmwRa3/FK vzrp6nSLX89AZwg4NixpQRsHfSw4kAy/vNYqFDmj/46CvZOuY+rQNxJMLVTk76II5KMb 7StzCUc0Gk3xcASZ7v+85xbg/AmlBLI9C+bi9ajiUUpI3fVcCrRZ6DwQvtYgeYUDlBPr MSxYwTNzR3toM7Ww6JZCAh3CEWSG/y24xkrmjRk/f2aEuYaDg2F2XgGUTFD6ZEvOjCM6 ktrKNYaPkCfWbRCkJsQsHQE77KvMiB4JUel22BfKo02tDP2vLQW+VRL+Bw4EkzSCQLcQ WFbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oxhoe6qvi5++Tcm34QYjpxvVrTyaf87PFGxTM5J5klQ=; b=HZMs7eiBWojm6tNjA30uerxeZC50eQMxJYonN2701Mehz6lpGD/IOXM+VdAE2tdDtJ ZXcuZvxaoYK2YbYCy3XpPfX1Z2GUBubis75dYdiG8ZOsHVGwCU9/s7etTgpNnT0VOzg8 eWJ3sYIlzCRPVdvBWAv2OiQrvHPb5W3PbQwu9nwzd72MyBx1Mj11dhxHnYYCEqjp3z0S LS2clDjZl5boIr9I1ws1R0WVZSJSLpwjtpzCRXplnWDYUUW9Sgoe7VA7GCVI3leDpV+3 O0o3y0KRt7od8tmhQ5pequvjIHEUSWVIcTcML8RE9O2unu5na8z60JwfAURuNUvMmfoS mHcA== X-Gm-Message-State: APjAAAX4Z4rb18MjRpflJ2teW04cqUiLJqko7XMSs4/WFc1dygfr0yMY jhdV/ktuLETEIHkmu8PUFMNgySAZSMIel1YgPmd0mA== X-Received: by 2002:a0c:96c4:: with SMTP id b4mr29430317qvd.2.1560901954609; Tue, 18 Jun 2019 16:52:34 -0700 (PDT) MIME-Version: 1.0 References: <20190618182502.GC203031@google.com> <4587569.x9DSL43cXO@kreacher> In-Reply-To: From: Joel Fernandes Date: Tue, 18 Jun 2019 19:52:23 -0400 Message-ID: Subject: Re: Alternatives to /sys/kernel/debug/wakeup_sources To: Tri Vo Cc: "Rafael J. Wysocki" , Sandeep Patil , Viresh Kumar , Hridya Valsaraju , Linux PM , "Cc: Android Kernel" , Greg Kroah-Hartman , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 7:15 PM Tri Vo wrote: [snip] > > > > > > > > > > Android userspace reading wakeup_sources is not ideal because: > > > > > - Debugfs API is not stable, i.e. Android tools built on top of it are > > > > > not guaranteed to be backward/forward compatible. > > > > > - This file requires debugfs to be mounted, which itself is > > > > > undesirable for security reasons. > > > > > > > > > > To address these problems, we want to contribute a way to expose these > > > > > statistics that doesn't depend on debugfs. > > > > > > > > > > Some initial thoughts/questions: Should we expose the stats in sysfs? > > > > > Or maybe implement eBPF-based solution? What do you think? > > > > > > We are going through Android's out-of-tree kernel dependencies along with > > > userspace APIs that are not necessarily considered "stable and forever > > > supported" upstream. The debugfs dependencies showed up on our radar as a > > > result and so we are wondering if we should worry about changes in debugfs > > > interface and hence the question(s) below. > > > > > > So, can we rely on /d/wakeup_sources to be considered a userspace API and > > > hence maintained stable as we do for other /proc and /sys entries? > > > > > > If yes, then we will go ahead and add tests for this in LTP or > > > somewhere else suitable. > > > > No, debugfs is not ABI. > > > > > If no, then we would love to hear suggestions for any changes that need to be > > > made or we simply just move the debugfs entry into somewhere like > > > /sys/power/ ? > > > > No, moving that entire file from debugfs into sysfs is not an option either. > > > > The statistics for the wakeup sources associated with devices are already there > > under /sys/devices/.../power/ , but I guess you want all wakeup sources? > > > > That would require adding a kobject to struct wakeup_source and exposing > > all of the statistics as separate attributes under it. In which case it would be > > good to replace the existing wakeup statistics under /sys/devices/.../power/ > > with symbolic links to the attributes under the wakeup_source kobject. > > Thanks for your input, Rafael! Your suggestion makes sense. I'll work > on a patch for this. Does that entail making each wake up source, a new sysfs node under a particular device, and then adding stats under that new node? thanks, - Joel