Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbVKWTGH (ORCPT ); Wed, 23 Nov 2005 14:06:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932204AbVKWTGG (ORCPT ); Wed, 23 Nov 2005 14:06:06 -0500 Received: from gate.crashing.org ([63.228.1.57]:9953 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S932209AbVKWTGB (ORCPT ); Wed, 23 Nov 2005 14:06:01 -0500 Date: Wed, 23 Nov 2005 13:02:59 -0600 (CST) From: Kumar Gala To: Sam Ravnborg cc: Paul Mackerras , , Subject: Re: [PATCH] powerpc: Add support for building uImages In-Reply-To: <20051123185523.GC8336@mars.ravnborg.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 27 On Wed, 23 Nov 2005, Sam Ravnborg wrote: > On Wed, Nov 23, 2005 at 12:43:15PM -0600, Kumar Gala wrote: > > + > > +$(obj)/uImage: $(obj)/vmlinux.gz > > + $(Q)rm -f $@ > > + $(call if_changed,uimage) > > + @echo -n ' Image: $@ ' > > + @if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi > > The above is suboptimal. The $(call if_changed,uimage) will execute > $(cmd_uimage) if 1) prerequisites has changed or 2) the command to execute > has changed. > In the above case 1) is always true, otherwise we would not reach the > statement. So change it to $(call cmd,uimage) is the correct way. > > The 'bug' is also present in ppc/boot/images thanks. I'll send a follow up patch to fix both cases. - kumar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/