Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp331060ybi; Tue, 18 Jun 2019 23:49:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+7JEMifmsJDuusFIGwmJKzAUbcM8SEOLqfyYDpZTGRbv0bcxHLrbjJ/FYw8on9wsnNf4O X-Received: by 2002:a62:fb0a:: with SMTP id x10mr18959462pfm.224.1560926995715; Tue, 18 Jun 2019 23:49:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560926995; cv=none; d=google.com; s=arc-20160816; b=RAMFub5VEac6IBP44aBkyQ7nCWvaU4lDIxAqRp3VuNnlmusrOJgVkjRaDeuVHSHuxK 4ykaazku9MvUVj4nUhvebsuhiEGPC8ZCCMPPyUSoRw+bCeU/SJmqC3d+ft+su/mVoVpL grQ1cA0rHG9up/3jF3uDlj4pBrZV19rWv1vXs+eHFfl0bHY8qGWK7fjbz3GmOqJsSN6p 7eBaehiuZ4BSPwq2ziljvyRupkukG+90GW/9fDXT8MaRS1f7v3cqOsiIWdY3O5SGH4bX vTRBrhVlqcOv+SJawYlqXisx97eY1CYEpNI8Bez+FWg2pMUA7prq4lfXvkimENvNI1JF BHQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=PycMFSyhScr1bc4UQS+Ga+J7Cj9Cl0KikgqchYDS8AE=; b=R/E0U1YSaxmqXn2QszGkXeBSNUOOb3JUEVmpXlD6HHGtuXtM2P24WfSZM058nFdCvb 6Oh9tY2hxNUq34iEz77S6lWHM7u4V4pEDNusVhOtuYo7DcctENXqfRXa4GvCCdyFF2ca LetGpmLsVoiyyZsjIrtvCOkgT9yyb50dGaI3B0vNGct4MQtYyH9OhEmcNjaXeK3jlHcY RgSKH3J2Lo+lk6Ef/rN9cNaBz9FIWAlEsunoprAKI5RXVSrs1jqRg8+3tB9KbeEy3yDz dFZEix03bYz74sGUo+DJLszZDggIc+U1PK2ST2Ni8EBKLApgFc1QVxtaG8km77RWs2M3 LNAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 200si12371140pfy.101.2019.06.18.23.49.40; Tue, 18 Jun 2019 23:49:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730888AbfFSGtT (ORCPT + 99 others); Wed, 19 Jun 2019 02:49:19 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:56527 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfFSGtT (ORCPT ); Wed, 19 Jun 2019 02:49:19 -0400 X-Originating-IP: 90.88.23.150 Received: from bootlin.com (aaubervilliers-681-1-81-150.w90-88.abo.wanadoo.fr [90.88.23.150]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 08665240017; Wed, 19 Jun 2019 06:49:12 +0000 (UTC) Date: Wed, 19 Jun 2019 08:49:21 +0200 From: Maxime Chevallier To: Nathan Huckleberry Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump Message-ID: <20190619084921.7e1310e0@bootlin.com> In-Reply-To: <20190618160910.62922-1-nhuck@google.com> References: <20190618083900.78eb88bd@bootlin.com> <20190618160910.62922-1-nhuck@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Nathan, On Tue, 18 Jun 2019 09:09:10 -0700 Nathan Huckleberry wrote: >There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' >Added a usage consistent with other fops to dump pmap >to userspace. Thanks for sending a fix. Besides the typo preventing your patch from compiling, you should also prefix the patch by "net: mvpp2: debugfs:" rather than "cls", which is used for classifier patches. Thanks, Maxime