Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190615040210.GA9112@hari-Inspiron-1545>
In-Reply-To: <20190615040210.GA9112@hari-Inspiron-1545>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Wed, 19 Jun 2019 11:55:14 +0200
Message-ID: <CAKv+Gu9-wiJNxPsVn06dBSU8Gchg8LjV=mi0cThZUWywmt2xzQ@mail.gmail.com>
Subject: Re: [PATCH] drivers: firmware: efi: fix gcc warning -Wint-conversion
To:     Hariprasad Kelam <hariprasad.kelam@gmail.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        tpmdd-devel@lists.sourceforge.net,
        Matthew Garrett <mjg59@google.com>
Cc:     linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

(+ Jarkko, tpmdd, Matthew)

On Sat, 15 Jun 2019 at 06:02, Hariprasad Kelam
<hariprasad.kelam@gmail.com> wrote:
>
> This patch fixes below warning
>
> drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of
> =E2=80=98tpm2_calc_event_log_size=E2=80=99 makes pointer from integer wit=
hout a cast
> [-Wint-conversion]
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>

I think we already have a fix queued for this, no?

> ---
>  drivers/firmware/efi/tpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c
> index 74d0cd1..1d3f5ca 100644
> --- a/drivers/firmware/efi/tpm.c
> +++ b/drivers/firmware/efi/tpm.c
> @@ -75,7 +75,7 @@ int __init efi_tpm_eventlog_init(void)
>                 goto out;
>         }
>
> -       tbl_size =3D tpm2_calc_event_log_size(efi.tpm_final_log
> +       tbl_size =3D tpm2_calc_event_log_size((void *)efi.tpm_final_log
>                                             + sizeof(final_tbl->version)
>                                             + sizeof(final_tbl->nr_events=
),
>                                             final_tbl->nr_events,
> --
> 2.7.4
>